-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype a Project Home Page #157
Comments
Here's a v1 for the Project-specific page. I'll take a stab at the Projects Page in the other issue next. Edit: Found a better wireframe tool. |
Second iteration of project page based off of wire frame made by @sarL3y |
I think the challenge with the banner is that we are trying to make something work for the banner that is only designed to work for the cards. Why don't we just request a different image from the projects for the project specific page. it allows them to come up with something that is more narrative. |
I like that idea @ExperimentsInHonesty, and I think that would also be a great image for the banner. I think in order for that to be implemented, we would have to create a banner property on the project cards. Because currently, the project page is a layout that jekyll is using, so I wouldn't be able to hard-code this in for this specific page, but would have to check for a variable that is part of the project yaml. |
@KianBadie in order to add a second image to the project's md file, we need to decide what to rename the current image field and a host of other questions. I am going to open an issue for this discussion and I will get back to you with his answer. |
@ExperimentsInHonesty Sounds good! |
Thanks for the explanation, I understand now. I'm often wary of making logic choices like this based on string matching, since it is so easy to introduce casing/spelling errors. On the other hand, it removes the need to update each project.md when a new "required" link comes online. On the other other hand, it also somewhat removes the distributed content editing nature of updates and requires a dev to come in and edit a template. Trade-offs! |
Answer 1. Created new issue #297 to change the project.md file format, and add logic to the project homepage include to render specific links at top. |
Currently waiting details about how to render the contributors and Languages of projects. |
@ExperimentsInHonesty @harishlingam |
@ysjiang18 We are taking a second look at the Project Home Page to improve its UI. Our question at the moment: how best can we display the contributors on the project? For instance, if a project has 20 contributors, do we show all of them on page-load, or a select portion? If a select portion, how can one view the remaining contributors if they so choose? |
@ExperimentsInHonesty @harishlingam GifStillsThe leadership card is built with mock data of what the expected github api calls will give us after it is parsed. The sources for all the images in the team seciton are the urls to the github profile pictures, so they were easy to obtain. Leadership section was hard coded into the project.md file (which from my understanding, is the way we plan to do it.) That will allow us to specify what role they play in the project as well as provide any links to forms of contact. |
@KianBadie @ExperimentsInHonesty @ysjiang18 Thanks for putting this together Kian. It's really helpful to see this iteration of the Project Home Page with dummy data added in. A couple requests: (1) Can you increase the margins between each project resource box as we did on last call? (2) Now seeing the photos added in, I propose we split test the resource boxes Monday evening with: (a) red color tabs (b) gray line (c) light gray color tabs. |
@ysjiang18 (Just copying my earlier message here): Basically, we are looking for a wireframe that iterates on the mockup we already have, specifically, improving the way contributors are shown beyond a certain number (drop down?carousel? etc.). Following that, how can we improve the look of the Getting Started carrot, which when clicked displays the content box immediately below? |
@KianBadie My proposed UI edits to the current version:
|
@KianBadie is currently working on the left right scroll problem identified by Joel, on this issue comment |
Sorry for the lack of documentation. Here is an update Current state of project home page on desktop (my local branch):A project with all the data we need (linked github repo, readme/wiki, defined project leadership, etc)Mobile iPhone 6/7/8A project missing a lot of the data we need (linked github repo, readme/wiki, defined project leadership, etc)Mobile iPhone 6/7/8Using these 2 example to show the 2 "opposite" ends of the spectrum of what the pages can look like. I currently have a pull request open to have the project home page be up to date with my local branch. I think the main differences on that pull request might be mobile styling rules. To see what the mobile styling updates look like, I have provided many examples in the pull request #363, using screens that are small, medium, and large. How to view the page on your desktopThe pages are actually currently integrated into the main site. Just type https://www.hackforla.org/projects/[INSERT_PROJECT_NAME]. The only caveat is that you need to type the [PROJECT_NAME] according to the file name on the website repo. For example, the "ArtWatcher" project url would be "https://www.hackforla.org/projects/adopt-civic-art". I am going to try to keep this comment readable, so I am going to avoid posting many screenshots and refer to the project page urls that are available now (however, they are not completely up to date to the gifs/pictures I have posted above. Those are currently on an open pull request). OtherThere are some things I wanted to talk about relating to the page.
Other than that I can't think of any other updates. My apologies for the information dump. If I think of more things I will edit this comment and add it. |
Prototype complete!!!! |
Overview
We want to start prototyping a dedicated page for each Project. These are already being rendered by Jekyll, but we need to add more details. This task will eventually roll up into #14.
Action Items
_layouts/project.html
The text was updated successfully, but these errors were encountered: