Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to change project.md file format to update "Looking For" #291

Closed
2 of 5 tasks
KianBadie opened this issue Feb 5, 2020 · 6 comments · Fixed by #336
Closed
2 of 5 tasks

Proposal to change project.md file format to update "Looking For" #291

KianBadie opened this issue Feb 5, 2020 · 6 comments · Fixed by #336
Assignees
Labels
Complexity: Missing enhancement New feature or request suggestion Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing

Comments

@KianBadie
Copy link
Member

KianBadie commented Feb 5, 2020

Overview

We want to accommodate the use of commas in "Looking For" descriptions.

Action Items

  • Edit a sample project md file in the following way
    Current State:
looking: One skill, another skill, a compound skill (part 1, part1)

Future State:

looking:
  - One skill
  - another skill
  - a compound skill (part 1, part 2)
  • write logic for project hompage include to display
  • add screenshot to issue
    • Get sign off by Bonnie
  • Edit all project files

Resources/Instructions

Additional dialogue on another issue regarding this topic

@KianBadie KianBadie added the enhancement New feature or request suggestion label Feb 5, 2020
@ExperimentsInHonesty ExperimentsInHonesty changed the title Revise "Looking For" display logic Proposal to change project.md file format to update "Looking For" Feb 6, 2020
@KianBadie
Copy link
Member Author

KianBadie commented Feb 9, 2020

@ExperimentsInHonesty
For my example I used the LA Metro Health Monitor project
Project card on homepage
Screenshot from 2020-02-08 17-33-33

metro-ontime.md code snippit:

looking: 
  - Frontend Developers (React, D3) 
  - Backend Developers (Python, Pandas)

current-projects.html logic code snippit:

                  {%- if item.looking -%}
                    <div class="project-needs">
                      <strong>Looking for: </strong>
                        {% for role in item.looking %}
                          {% if forloop.last == false %}
                            <p style='display:inline;'>{{ role }}, </p>
                          {% else %}
                            <p style='display:inline;'>{{ role }}</p>
                          {% endif %}
                        {% endfor %}
                    </div>
                  {%- endif -%}

I avoided putting the styling rule in a class because I wanted to avoid making a class for just one rule.

@ExperimentsInHonesty
Copy link
Member

This is the code for displaying links

{%- if item.links -%}
                    <div class="project-links">
                      <strong>Links: </strong> 
                        {%- for item in item.links -%} 
                          <a href={{ item.url }} rel="noopener" target='_blank'> {{ item.name }}</a>{%- if forloop.last == false -%},
                          {%- endif -%}
                        {%- endfor -%}

@ExperimentsInHonesty
Copy link
Member

progress report is

  1. Progress - mostly done, will update based on comments (making it similar to existing links section)
  2. Blocks - none
  3. Availability - sunday/monday no problem.
  4. ETA 2/10

@KianBadie
Copy link
Member Author

Update with revisions in code @ExperimentsInHonesty. The code is written to be identical to the way it is implemented in the links section.

Screenshot:
Screenshot from 2020-02-10 12-33-06

Revision in code:

                  {%- if item.looking -%}
                    <div class="project-needs">
                      <strong>Looking for: </strong>
                        {% for role in item.looking %}
                          <p style='display:inline;'> {{ role }}</p>{% if forloop.last == false %},
                          {% endif %}
                        {% endfor %}
                    </div>
                  {%- endif -%}

@KianBadie
Copy link
Member Author

@ExperimentsInHonesty I totally forgot if we talked about this/made a decision last night, but is my example/code clear to go? Should I add it to the rest of the project cards?

@cnk
Copy link
Member

cnk commented Feb 12, 2020

@KianBadie I am not Bonnie but I think your code looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing enhancement New feature or request suggestion Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing
Projects
4 participants