Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Design system heading typography in the code base #1743

Closed
4 tasks done
Sihemgourou opened this issue Jun 15, 2021 · 3 comments · Fixed by #1814
Closed
4 tasks done

Implement Design system heading typography in the code base #1743

Sihemgourou opened this issue Jun 15, 2021 · 3 comments · Fixed by #1814
Assignees
Labels
Complexity: Medium Feature: Design system milestone: missing role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours To Update ! No update has been provided

Comments

@Sihemgourou
Copy link
Contributor

Sihemgourou commented Jun 15, 2021

Overview

We need to implement the headings part of the design system as classes in the code base so that our heading sizes are no longer attached to h1/h2/h3 tags etc and can no longer negatively affect the accessibility/hierarchy of the web pages for people using screen readers

Action Items

  • Go to the Figma Design System page Typography section on the top row
  • Read the Start Here if you do not know about design systems (*Danielle note: sorry, the developer summary isn't there yet! But the designer one still explains the basics)
  • Find the headings (from Title1 to Title6 ) in the figma link (See 1.Style & Rules => Typography)
  • Add new classes Title1 through Title6 with only the size properties (not the other properties like typeface, line height etc. at this time because that may be automatically applied to all typography on the site elsewhere) into the code base in the appropriate scss file (the classes will be implemented in headings throughout the site in a future issue in collaboration with design, after this step is finished)

Screen Shot 2021-06-17 at 3 43 02 PM

Resources/Instructions

Figma

@Sihemgourou Sihemgourou added role: front end Tasks for front end developers Complexity: Medium labels Jun 15, 2021
@Sihemgourou Sihemgourou changed the title Implement Design system on the code base Implement Design system in the code base Jun 15, 2021
@daniellex0 daniellex0 changed the title Implement Design system in the code base Implement Design system heading typography in the code base Jun 17, 2021
@Zak234 Zak234 self-assigned this Jun 19, 2021
@sayalikotkar sayalikotkar added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@Sihemgourou Sihemgourou added Feature: Design system and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Jun 20, 2021
@Sihemgourou Sihemgourou added the To Update ! No update has been provided label Jun 28, 2021
@github-actions
Copy link

@Zak234 Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou
Copy link
Contributor Author

@Zak234 Please add uptades on this issue before taking another one (I unassigned you from this one but Please feel free to take it back once you finish working on this issue.

@edeneault
Copy link
Member

Question/clarification: Are these new typography classes meant to only affect the sizes of the "toolkit" page? or should they be set-up to be applied "site wide"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Design system milestone: missing role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours To Update ! No update has been provided
Projects
Development

Successfully merging a pull request may close this issue.

6 participants