Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply design system heading classes to Homepage #2085

Closed
3 tasks done
kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2195
Closed
3 tasks done

Apply design system heading classes to Homepage #2085

kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2195
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 10, 2021

Overview

We need to apply the new standardized heading classes to the Home page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.

Action Items

  • Apply the heading classes noted in the Home page Figma file (on the left inside a pink rectangle) to the Home page
  • Make sure the headings still look good and correct (same as the Figma) both in mobile and desktop (there is no reference for the mobile version on Figma yet, but make sure it looks fine), and that nothing gets messed up due to these changes
  • Make sure to adjust the heading h tags if needed so that they reflect the correct hierarchy of the page for screen readers (since the styling no longer relies on the h tags)

Resources/Instructions

Home page Figma file (on the left inside a pink rectangle)
Home page
From Figma:
Screen Shot 2021-08-08 at 1 41 32 AM
Screen Shot 2021-08-08 at 1 41 39 AM

@kristine-eudey kristine-eudey added role: front end Tasks for front end developers P-Feature: Home page https://www.hackforla.org/ Feature: Design system Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Aug 10, 2021
@sheltoG sheltoG added this to the z. Accessibility milestone Aug 18, 2021
@Zhu-Joseph Zhu-Joseph self-assigned this Aug 27, 2021
@Zhu-Joseph
Copy link
Member

Progress - Began reading through code and standardized heading classes
Blockers - None so far
Availability - Random time here and there
ETA - End of next week if not earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Home page https://www.hackforla.org/ role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

7 participants