Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refactor/standardization of all buttons within Communities of Practice/Program Areas Page #2158

Closed
7 tasks done
abuna1985 opened this issue Aug 22, 2021 · 7 comments · Fixed by #2352
Closed
7 tasks done
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor HTML role: front end Tasks for front end developers size: missing To Update ! No update has been provided

Comments

@abuna1985
Copy link
Member

abuna1985 commented Aug 22, 2021

Overview

We need to refactor for buttons within the Home page from the recommendations in the CSS standardization spreadsheet (resource below) so that we have a consistent button appearance through the HfLA site.

Note: The buttons should have the same length and width after the changes. if it is not, please add CSS styling to make sure they match.

Action Items

  • Make the 3 recommended edits for the buttons from the spreadsheet below (2 files will be updated)
    • Update line 68 of website/pages/communities-of-practice.html with HTML from the Reccomendation column
    • Update line 70 of website/pages/communities-of-practice.html with HTML from the Reccomendation column
    • Update line 87 of website/pages/program-areas.html with HTML from the Reccomendation column
  • Confirm after the recommended edits that the Action of each button works as intended within the Communities of Practice/Join Us/Program Areas page
  • Confirm the button length/width within the page are the same after changes. If not refactor CSS (this can be accomplished with custom padding for the specific button element or length/width CSS properties)
  • Create a Pull Request with the proposed changes to the button

Resources/Instructions

Google Sheets - CSS Standardization Buttons
#1921

@github-actions
Copy link

Hi @abuna1985.

Good job adding the required labels to this issue.

Just a friendly reminder to also move the issue into the "New Issue Approval" column under the Project Board. For more info on that, check Github's documentation here.
Thanks!

Additional Resources:
Wiki: How to add status labels to issues (WIP. Link will be updated when the wiki is done)
Wiki: How to create issues (WIP. Link will be updated when the wiki is done)

@abuna1985 abuna1985 added Ready for Prioritization Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Complexity: Medium labels Aug 22, 2021
@abuna1985 abuna1985 changed the title Complete refactor/standardization of all buttons within Communities of Practice/Join Us/Program Areas Page Complete refactor/standardization of all buttons within Communities of Practice/Program Areas Page Aug 23, 2021
@ExperimentsInHonesty ExperimentsInHonesty added the Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages label Aug 25, 2021
@abuna1985 abuna1985 added the Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages label Aug 29, 2021
@abuna1985 abuna1985 added Feature: Refactor HTML and removed Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages labels Sep 7, 2021
@mehmehmehlol mehmehmehlol self-assigned this Sep 16, 2021
@github-actions github-actions bot added the To Update ! No update has been provided label Sep 17, 2021
@github-actions
Copy link

@mehmehmehlol

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 14, 2021 at 12:02 AM PST.

@github-actions github-actions bot added To Update ! No update has been provided and removed To Update ! No update has been provided labels Sep 24, 2021
@github-actions
Copy link

@mehmehmehlol

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST.

@github-actions github-actions bot removed the To Update ! No update has been provided label Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

@mehmehmehlol

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 28, 2021 at 12:02 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Oct 1, 2021
@mehmehmehlol mehmehmehlol removed their assignment Oct 4, 2021
@abuna1985 abuna1985 removed the To Update ! No update has been provided label Oct 4, 2021
@Zhu-Joseph Zhu-Joseph self-assigned this Oct 10, 2021
@Zhu-Joseph Zhu-Joseph added the Status: Updated No blockers and update is ready for review label Oct 10, 2021
@Zhu-Joseph
Copy link
Member

Progress: Reviewing CSS sheet and code
Blockers: None
Availability: Random hours here and there
ETA: End of week

@abuna1985
Copy link
Member Author

@Zhu-Joseph I have added an action item. My apologies for not being clear with the issue. If you need assistance creating styling for the buttons, feel free to reach out to me.

@github-actions github-actions bot added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Oct 15, 2021
@github-actions
Copy link

@Zhu-Joseph

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 12, 2021 at 12:02 AM PST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system Feature: Refactor HTML role: front end Tasks for front end developers size: missing To Update ! No update has been provided
Projects
Development

Successfully merging a pull request may close this issue.

5 participants