Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing comment on 2FA Guide Page #2657

Closed
3 tasks done
JessicaLucindaCheng opened this issue Jan 5, 2022 · 2 comments · Fixed by #2729
Closed
3 tasks done

Fixing comment on 2FA Guide Page #2657

JessicaLucindaCheng opened this issue Jan 5, 2022 · 2 comments · Fixed by #2729
Assignees
Labels
good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jan 5, 2022

Overview

As developers, we need to make sure any comments we make in the code do not show up on the live website and that code comments are easy to understand. For this issue, we will add the end tag --> on a comment so it does not show on the bottom of the 2FA Guide page and we will indent the comment start tag to make it easier to understand the code.

Screenshot of problem: Comment seen on bottom of 2FA Guide page bottom-of-2fa-page

Action Items

In _guide-pages/2FA.html,

  • Line 85-86 currently looks like this:
    <!-- Refactor Javascript, moved script to 2FA.js, issue #2068   
        <div class='section-container' style="display: none;">
    
    Indent the start of the comment on line 85 so that the result is:
        <!-- Refactor Javascript, moved script to 2FA.js, issue #2068   
        <div class='section-container' style="display: none;">
    
  • Line 103-104 currently looks like this:
        </div>
    </div>
    
    Add an indented comment end tag --> after line 103 so that the result is:
        </div>
        -->
    </div>
    
  • Check that all features on the page still work

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added the P-Feature: Toolkit https://www.hackforla.org/toolkit/ label Jan 5, 2022
@github-actions

This comment has been minimized.

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Size: Good second issue size: 1pt Can be done in 4-6 hours and removed role missing size: missing labels Jan 8, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Fixing comment on 2FA Guide Page Fixing comment on 2FA Guide Page Jan 8, 2022
@pattshreds pattshreds self-assigned this Jan 22, 2022
@JessicaLucindaCheng

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants