Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing comment on 2FA Guide Page #2729

Merged

Conversation

tamara-snyder
Copy link
Member

Fixes #2657

What changes did you make and why did you make them ?

  • Indented opening comment tag on line 85 of _guide-pages/2FA.html to be in line with the commented-out opening <div> tag
  • Added closing comment tag on line 104 to keep comment from appearing on the 2FA Guide Page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

issue2657_before

Visuals after changes are applied

issue2657_after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b tamara-snyder-close-comment-tag-2657 gh-pages
git pull https://github.com/tamara-snyder/website.git close-comment-tag-2657

@github-actions github-actions bot added P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Size: Good second issue labels Jan 31, 2022
@SAUMILDHANKAR SAUMILDHANKAR self-requested a review February 1, 2022 09:49
Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamara-snyder Thank you for working on this issue. I can see the changes in my environment. Great job!
Just want to add a couple of quick notes for your next issue, please add your ETA and availability when you pick up an issue, also, add your PR to the Project Board by clicking on the gear icon next to projects. This makes it easier for the whole team to track progress. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing comment on 2FA Guide Page
3 participants