-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate use of GitHub Bundler for testing HfLA website locally without Docker #4409
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Hi @LOSjr4, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: M,T,TH (9AM-1PM) |
Update 5/23/23 THE INFORMATION IN THIS COMMENT IS INCORRECT! This did not solve the problem, it was an uncorrelated temporary fix that did not work while trying to repeat the steps. I no longer believe raw/endraw is relevant to this issue. This morning I did a google search and luckily found this blogpost https://www.tomordonez.com/curly-braces-markdown-jekyll/ that simply explains and solved my viewing issue. Basically, because "{{ site.url }}" has double curly braces around them, that part of the code doesn't show up. Adding {%raw%} and {%endraw%} tags before and after enables jekyll to see the code and the localhost preview works as intended. |
My install notes: (on a Windows 10 pro) |
Hi @LOSjr4 this is great; thank you for solving some tricky problems in your investigation. Could you add to your last comment, the command(s) that a dev would use to build the site? That will be useful if we write a follow-up issue to create a wiki page with instructions. Also, I'm trying to understand the context of the changes you describe in main.scss. Any links to documentation or even slackoverflow links would be helpful. You mentioned that you created an issue branch. I don't think we were expecting a PR for this issue but please advise, what files were committed in that branch? |
@roslynwythe My initial trouble was understanding how to install Bundler. The Bundler website says to type in "bundle install" but the trick was to type "gem" first to call upon Ruby (I suppose) and then add bundler from there. https://stackoverflow.com/questions/10012181/bundle-install-returns-could-not-locate-gemfile the commands I followed can be found halfway down the page) The only thing added to the main.scss page to make jekyll work was the {%raw%}{%endraw%}(<--THIS PART IS INCCORECT 5/23/23). Differences shown below. |
Thank you @LOSjr4 , that comment was very helpful. Please move the issue into the "Questions/In Review" column" and I will find our from Justin our dev lead, how the review should proceed. |
@roslynwythe The main GitHub article posted in this issue regarding Bundler would not install as written. I had found a stackoverflow forum that helped with the install process. The problem with actually testing Bundler is it would constantly put up these two errors Also when Bundler did work the website preview initially appears broken as shown in previous comments. Here is a silly way to get it to work consistently. Delete the six dashes at the top of website/assetes/css/main.scss (important first step), save and type 'bundle exec jekyll serve' in the terminal. I thought it could be a formatting issue with the way our scss is written. It might also be a issue with Bundler not being able to follow @import "main". I've researched several of these troubleshooting ideas and I haven't been able to figure it out. This Bundler testing issue has grown into something more complicated, and Docker seems to work without flaw. That is why I don't believe it is feasible to continue efforts trying to make Bundler work. |
Hi @LOSjr4 thank you for the comment outlining your findings. That is exactly what we are looking for, except that I did not realize that now, for feasibility study issues such as this, a DR (Decision Record) should also be written for our wiki. Since the wiki is not fully migrated and ready for editing, you should create another comment in this issue, using this format. This page describes the process to draft and track DRs during this period, until the wiki is ready for editing. Basically all you have to do is copy the link from your draft DR comment and enter it into that page. I edited the last Action Item to mention the DR and I apologize for the omission. Thank you for your thorough analysis on this issue. I'm going to put the issue back in |
DR: Investigate use of GitHub Bundler for testing HfLA website locally without DockerThis is a record in the Decision Records on Solutions Not Implemented. IssueProblem Statement
Potential Solution
Feasibility Determination
|
Overview
It would be desirable to have an alternate means for developers to run the HfLA website locally without the use of Docker. In this issue we will investigate the use of Bundler for the installation and execution of Jekyll.
Action Items
Resources/Instructions
The text was updated successfully, but these errors were encountered: