-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projects and Home Pages: Pin Projects Filter to the Top of the Projects List #4593
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @Anahisv23, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
i. Availability: 11am - 5pm |
@Anahisv23 Please move this to the in progress column |
Hey @ExperimentsInHonesty the issue has been moved to the in progress section on the project board. |
I had a question regarding issue #4593. I’m trying to understand what the issue is asking. So in the details section of the issue when it says that I need to make the projects filter stay at the top of the content section. If I’m understanding correctly do I need to move the “Applied Filters” div with the class "filter-tag-container" on current-guides.html on line 23 that pops up when a user selects a project filter to the section containing the projects right under the search bar (above the projects list) to make the behavior similar to the REI website? Since in the REI website applied filters are positioned above the product list. |
Hi @Anahisv23! Great job catching the detail that the filter chip position on the example REI link is different from our projects page. I read the issue as focused on adding the fixed behavior the filter sidebar and search bar. @Adastros can you clarify if the selected filter chips should be moved in addition to fixing the filters sidebar and search bar? |
@LRenDO @Anahisv23 I don't believe we want to change the position of the "Applied Filters" chips to match the REI site, but to confirm, I put the question on the agenda for the PM/dev lead meeting of 3/25 and I'll report back. Thank you both for work on this issue! |
@Anahisv23 Don't change the location of anything (filters, selected filter items, or search bar). Just figure out how to:
I hope that answers your question. If not, please add this issue back to the questions column, with the ready for dev lead label and additional questions. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Tuesday, March 26, 2024 at 12:06 AM PST. |
Progress: Currently on vacation so haven’t made much progress on this but will work on this issue next week. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Tuesday, April 9, 2024 at 12:06 AM PST. |
Progress: I'm still working on this. I've managed to update the styling for the filter so that the filter is anchored to the top of the parent section element and added independent scroll to the filter. Still working on pinning the search bar and independent scroll for project lists. |
Progress: Still working on this issue. I've managed to allow independent scroll for projects list and filters. Still need to pin filter and search bar to top of the section element. |
Overview
We need to improve the usability of the filters, search and project display so that it is easy for people to navigate the project list.
Details
See how the REI website implements their page when scrolling through the merchandise on the website. The projects filter and list should look and behave similar to it.
The difference between REI and ours is that we have a search bar, that will stay pinned at the top.
Action Items
Resources/Instructions
The text was updated successfully, but these errors were encountered: