Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Developers are creating branches off hackforla/website #4876

Open
3 of 11 tasks
roslynwythe opened this issue Jun 23, 2023 · 9 comments
Open
3 of 11 tasks

ER: Developers are creating branches off hackforla/website #4876

roslynwythe opened this issue Jun 23, 2023 · 9 comments
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Dependency An issue is blocking the completion or starting of another issue ER Emergent Request Feature: Administrative Administrative chores etc. Issue Making: Level 2 Make issue(s) from an ER or Epic role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jun 23, 2023

Dependency

Emergent Requirement - Problem

Developers inadvertently create extraneous branches off the hackforla/website repository (instead of creating branches on their fork) but they do not have rights to delete the extraneous branches. We need to prevent developers from creating these branches, and we require an issue template for instances for use when such a branch has been created and needs to be deleted.

Issue you discovered this emergent requirement in

  • N/A

Date discovered

discussed at meeting 6/12/2023

Did you have to do something temporarily

  • YES
  • NO

We are currently pruning the branches manually, which is a waste of time.

Who was involved

Bonnie Wolfe, @JessicaLucindaCheng

What happens if this is not addressed

The branches will persist until deleted by a lead and the lead will need to figure out which branches can be deleted, which can take a lot of time and research.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  • prevent write members who are not part of merge team from creating branches

    • @JessicaLucindaCheng implemented the solution for preventing members (aside from merge team) from creating branches off hackforla/website in the future by doing the following:

      Click here to see the detailed instructions
      1. On the repo, select Settings.
      2. On the left menu, select Branches.
      3. Select Edit for the branch rule named *. (Yes, the branch rule is named with the asterisk symbol).
      4. Scroll toward the bottom of the page. Then, you'll see the Restrict pushes that create matching branches; make sure the checkbox next to it is selected.
        restrict making branch
  • Write an issue for a back-end developer to work on creating an issue template that includes both:

    • A section for reporting that a branch created on the Website repo needs to be removed
    • A section with instructions for how to remove the branch.
      • Instructions can be copied and pasted from [Insert link to instructions] into the issue template
@roslynwythe roslynwythe added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Accessibility Issues that would broaden website accessibility Feature Missing This label means that the issue needs to be linked to a precise feature label. size: 1 pt labels Jun 23, 2023
@roslynwythe roslynwythe self-assigned this Jun 23, 2023
@github-actions github-actions bot removed the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 23, 2023
@github-actions

This comment was marked as outdated.

@kimberlytanyh kimberlytanyh added size: 1pt Can be done in 4-6 hours and removed size: 1 pt labels Jul 9, 2023
@kimberlytanyh kimberlytanyh added the ER Emergent Request label Sep 10, 2023
@roslynwythe

This comment was marked as resolved.

@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Nov 27, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added Feature: Onboarding/Contributing.md and removed Feature: Accessibility Issues that would broaden website accessibility labels Feb 19, 2024
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 4, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Draft Issue is still in the process of being created label Mar 4, 2024

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Issue Making: Level 2 Make issue(s) from an ER or Epic labels Mar 4, 2024
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization Feature: Administrative Administrative chores etc. and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 4, 2024
@JessicaLucindaCheng

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Ready for Prioritization labels Mar 4, 2024
@ExperimentsInHonesty

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added Dependency An issue is blocking the completion or starting of another issue ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 5, 2024
@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 5, 2024

@ExperimentsInHonesty

@JessicaLucindaCheng I updated the possible solutions template part. From

Write an issue for a back-end developer to work on creating an issue template for reporting that a branch created by the Merge Team needs to be removed.

to

Write an issue for a back-end developer to work on creating an issue template for reporting that a branch created by the Merge Team needs to be removed. The issue template can be the report and the instructions for removing all in one.

If you agree, add ready for prioritization label, otherwise leave comment.

  • I think the report and instructions can be included in the issue template together. However, I think a person on the website-admins team would have to write the instructions because I don't think other members of the team would necessarily know how within the context of the repo's branch rules set up. So, I wrote How to delete a branch from the Website repo #6416.
  • Also, I rewrote the instructions to be:
  • Write an issue for a back-end developer to work on creating an issue template that includes both:
    • A section for reporting that a branch created on the Website repo needs to be removed
    • A section with instructions for how to remove the branch.
      • Instructions can be copied and pasted from [Insert link to instructions] into the issue template

Next steps

@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Added to dev/pm agenda ready for product labels Mar 18, 2024
@JessicaLucindaCheng
Copy link
Member

Merge Team member or Technical Lead

  • Once the issue in the Dependency section of this ER is closed, review this ER and make it ready for prioritization. Add a ready for prioritization label.

@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Dependency An issue is blocking the completion or starting of another issue ER Emergent Request Feature: Administrative Administrative chores etc. Issue Making: Level 2 Make issue(s) from an ER or Epic role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

4 participants