Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img Tag Refactor: CONTRIBUTING.md giphy-downsized-large.gif #5146

Closed
3 tasks done
Tracked by #6453
roslynwythe opened this issue Aug 6, 2023 · 10 comments · Fixed by #7068
Closed
3 tasks done
Tracked by #6453

img Tag Refactor: CONTRIBUTING.md giphy-downsized-large.gif #5146

roslynwythe opened this issue Aug 6, 2023 · 10 comments · Fixed by #7068
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 6, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • In your local IDE, open 'CONTRIBUTING.md' and navigate to Section 3.1.b
  • Remove the ending slash in the img HTML tag by changing
<img src="https://media.giphy.com/media/WT7SDqqKLWnjC1ppHV/giphy-downsized-large.gif" />

to

<img src="https://media.giphy.com/media/WT7SDqqKLWnjC1ppHV/giphy-downsized-large.gif">

**- [ ] The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.

  • Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL
https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/roslynwythe/website/blob/test-CONTRIB/CONTRIBUTING.md)

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
  2. Webpage(s): https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
  3. This issue is part of epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 6, 2023
@github-actions

This comment was marked as outdated.

@roslynwythe roslynwythe added good first issue Good for newcomers Feature: Wiki role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Ready for Prioritization ready for product and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. Complexity: Missing size: missing Ready for Prioritization labels Aug 6, 2023
@roslynwythe

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Aug 6, 2023
@roslynwythe

This comment was marked as outdated.

@roslynwythe roslynwythe added ready for product Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed good first issue Good for newcomers labels Aug 7, 2023
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 7, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Aug 8, 2023
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 9, 2023
@roslynwythe

This comment was marked as outdated.

@roslynwythe roslynwythe added the Dependency An issue is blocking the completion or starting of another issue label Aug 9, 2023
@roslynwythe

This comment was marked as outdated.

@roslynwythe roslynwythe closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
@roslynwythe roslynwythe added Ready for Prioritization and removed Dependency An issue is blocking the completion or starting of another issue labels Oct 11, 2023
@JessicaLucindaCheng

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added Ignore: Duplicate Issue or pull request is a duplicate and removed Ready for Prioritization labels Nov 6, 2023
@roslynwythe roslynwythe reopened this Mar 11, 2024
@roslynwythe roslynwythe changed the title img Tag Refactor: CONTRIBUTING.md image ending in 1268d86662a4.jpg img Tag Refactor: CONTRIBUTING.md image ending in giphy-downsized-large.gif Mar 11, 2024
@roslynwythe roslynwythe changed the title img Tag Refactor: CONTRIBUTING.md image ending in giphy-downsized-large.gif img Tag Refactor: CONTRIBUTING.md image giphy-downsized-large.gif Mar 11, 2024
@roslynwythe roslynwythe changed the title img Tag Refactor: CONTRIBUTING.md image giphy-downsized-large.gif img Tag Refactor: CONTRIBUTING.md giphy-downsized-large.gif Mar 11, 2024
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed Ignore: Duplicate Issue or pull request is a duplicate labels Jun 4, 2024
@ExperimentsInHonesty ExperimentsInHonesty added Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level and removed Ready for Prioritization labels Jun 9, 2024
@ExperimentsInHonesty ExperimentsInHonesty removed the Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level label Jun 23, 2024
@Kle012 Kle012 self-assigned this Jun 26, 2024
Copy link

Hi @Kle012, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Kle012
Copy link
Member

Kle012 commented Jun 26, 2024

i. Availability: 06/26/2024 1PM-5PM
ii. ETA: 06/26/2024 5PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Development

Successfully merging a pull request may close this issue.

4 participants