-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
img Tag Refactor in Contributing.md page #7068
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kle012 thanks for working on this issue. You correctly changed the tag on CONTRIBUTING.md on line 881 and left no space before the closing bracket. The linked issue is correct and into and from branch look correct.
However I see that you added some \ on line 43 and 46 on CONTRIBUTING.md. I'm sure you probably added them by mistake but once you remove these \ you should be good to go!
Hi @Anahisv23, |
Hi @Kle012, hmm thats strange. Have you tried removing these backslashes on your Github PR on the files changed tab? You could try that and see if that removes the backslashes. Let me know if that works. |
Hi @Anahisv23, I was able to remove the backslashes. Thank you so much for your advice. Please let me know if there is any issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kle012 thanks for addressing the backslash issue and no problem I'm glad that solved the problem. Everything looks good on my end. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kle012 - Great work on this pull request!
- You created the pull request using the correct branch.
- The issue is properly linked to the pull request.
- Your summary of changes is clear and concise.
- Your code change is clean and accurate.
Thanks for your contribution!
) * updated-team-meeting-data-6920 * Update contributor and language data * Update contributor and language data * Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038) * Update contributor and language data * Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036) * PBB migration "Issue Trigger" (#7053) * Update issue-trigger.yml Changes in prep for Projects Beta migration * Update issue-trigger.yml space added to comment * Update issue-trigger.yml edits to comment at Team Members * Update preliminary-update-comment.js refactoring for PBB migration * PBB migration "Pull Request Trigger" (#7054) * Update pull-request-trigger.yml edits for PBB migration * Update pull-request-trigger.yml remove test branch * PBB migration "Schedule Friday" (#7055) * Update schedule-fri-0700.yml Changes for PBB migration * Update add-label.js * Update find-linked-issue.js For PBB migration * Update add-label.js remove refs to personal repo * Update add-label.js addressing CodeQL alert * Update add-label.js address CodeQL alert * PBB migration "Move Closed Issues" (#7056) * Update move-closed-issues.yaml for migration to PBB * Update sort-closed-issues.js * Add github-handle for Roland Abregorivas in heart.md #6940 (#7009) * github-handle variable added for Gian Reyes Dionisio #6937 (#6984) * Update contributor and language data * updated role for Will Gillis on website project profile (#7063) * Add github handle for Marie (#7059) * added github handle element for Tien Yuan in heart.md (#7069) * Update contributor and language data * Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. * Update Roslyn's role to Developer Co-Lead (#7070) * img Tag Refactor in Contributing.md page (#7068) * Update contributor and language data * Added github-handle to Adrian Inchauste's section (#7074) * Update contributor and language data * edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040) * 6786 remove bop from untaggedrepoids in get project datajs (#7062) * remove references to BoP's id from the `untaggedRepoIds` list * Update contributor and language data * Revert `github.repository` post GHA test * Resolve merge conflicts * Resolve merge conflicts (p2) --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> * Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082) * Update meeting data * Update contributor and language data * Update Inactive Members JSON * Revert "updated-team-meeting-data-6920 (#7043)" (#7086) This reverts commit dc11c65. * Update contributor and language data * Update contributor and language data * updated team meeting data on events page to show meeting frequency * Add 'Leadership Option' to Issue Template for CoP Information Update (#7077) * add leadership type option with dropdown fields * remove whitespace between labels and body * remove whitespace in title * remove whitespace in front of the yes/no options * change default type * Update contributor and language data * Updated spell checker to ignore memebers names (#7073) * Update contributor and language data * Update contributor and language data * truncate contributors name in filter tag with ellipis (#7052) * Update contributor and language data --------- Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: David Cotelessa <david@cotelessa.com> Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com> Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com> Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com> Co-authored-by: williamzhang <willzhang73@gmail.com> Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com> Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com> Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com> Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com> Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com> Co-authored-by: duojet2ez <epstringskip@gmail.com> Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com> Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com> Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com> Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
Fixes #5146
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)