Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Leadership Option' to Issue Template for CoP Information Update #7077

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Add 'Leadership Option' to Issue Template for CoP Information Update #7077

merged 5 commits into from
Jul 5, 2024

Conversation

DrAcula27
Copy link
Member

Fixes #6862

What changes did you make?

  • Changed Leadership Type: NO to have a YES/NO dropdown
  • Added the following text under the dropdown:
    • If YES on Change Leadership Type, choose the Leadership Type; if NO, leave the field with the NA value:
  • Added a dropdown directly below the Leadership Type dropdown with the following values:
    • N/A
    • Mentor Led
    • Community Led
  • Set N/A as the default value

Why did you make the changes (we will use this info to test)?

  • To allow CoP co-leads to make issues to update their CoP's details

For Reviewers

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

  • No visual changes to the website

Resources

  • testing issue templates
    • Note: The following steps were skipped per @roslynwythe
      • Browse to the Issues page, then click Labels
      • Create labels corresponding to each label that was listed in the updated issue template. The color of the labels don't have to match those on the hackforla/website repository, but the text of the labels must match exactly.

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DrAcula27-leadership-option-6862 gh-pages
git pull https://github.com/DrAcula27/website.git leadership-option-6862

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 28, 2024
@muninnhugin muninnhugin self-requested a review June 28, 2024 18:10
@muninnhugin
Copy link
Member

Reviewing this PR.
ETA: end of Sunday.
Availability: Friday evening, Sunday.

@roslynwythe roslynwythe mentioned this pull request Jun 30, 2024
Closed
roslynwythe
roslynwythe approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@roslynwythe roslynwythe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @DrAcula27

  • code change is clean and correct
  • made use of the new GitHub issue forms feature
  • PR is well-formed and descriptive

Thank you for following the process to test the issue form in the context of your fork of the website repository, and providing a link to assist reviewers to do the same.

muninnhugin
muninnhugin approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@muninnhugin muninnhugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DrAcula27,

  • branching looks good
  • relevant issue is linked
  • code edit is clean
  • changes showed up correctly in the test link
  • PR description looks good

Great work on this issue. Thank you for contributing!

@zkamenov zkamenov self-requested a review July 2, 2024 18:46
@zkamenov
Copy link
Member

zkamenov commented Jul 2, 2024

Review ETA: 12:45 PDT 7/2/2024
Availability: 11:45-3:45 PDT 7/2/2024

zkamenov
zkamenov approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@zkamenov zkamenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes appear to be accurate and solve the issue. The updated template appears as it should. Thank you for solving this issue!

@t-will-gillis t-will-gillis merged commit 3792515 into hackforla:gh-pages Jul 5, 2024
6 checks passed
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 13, 2024
@DrAcula27 @terrencejihoonjung
Add 'Leadership Option' to Issue Template for CoP Information Update (h…
056ac27 
…ackforla#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org>
Co-authored-by: David Cotelessa <david@cotelessa.com>
Co-authored-by: Santiago Secco <53095957+santisecco@users.noreply.github.com>
Co-authored-by: Will Gillis <40799239+t-will-gillis@users.noreply.github.com>
Co-authored-by: Jennifer Sung <72041281+jennisung@users.noreply.github.com>
Co-authored-by: williamzhang <willzhang73@gmail.com>
Co-authored-by: Melissa McGrath <157540251+melissam640@users.noreply.github.com>
Co-authored-by: Austin Labador <67137399+alabador@users.noreply.github.com>
Co-authored-by: Matthew McCane <78394982+DakuwoN@users.noreply.github.com>
Co-authored-by: Kim <109393217+Kle012@users.noreply.github.com>
Co-authored-by: Christopher Chang <64837366+cchrizzle@users.noreply.github.com>
Co-authored-by: duojet2ez <epstringskip@gmail.com>
Co-authored-by: Mateo Rodriguez <79176075+mrodz@users.noreply.github.com>
Co-authored-by: Danielle Andrews <62191468+DrAcula27@users.noreply.github.com>
Co-authored-by: vanessasinam <85697744+vanessasinam@users.noreply.github.com>
Co-authored-by: Aadil Ahmed <aadilahmed0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roslynwythe roslynwythe roslynwythe approved these changes

@muninnhugin muninnhugin muninnhugin approved these changes

@zkamenov zkamenov zkamenov approved these changes

Assignees
No one assigned
Labels
Complexity: Medium Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'Leadership Option' to Issue Template for CoP Information Update
5 participants
@DrAcula27 @muninnhugin @zkamenov @roslynwythe @t-will-gillis