Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL alert 21 and 23 "Potentially unsafe external link" #6230

Closed
8 tasks
Tracked by #5129
roslynwythe opened this issue Feb 5, 2024 · 3 comments
Closed
8 tasks
Tracked by #5129
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Code Alerts manual dependency release role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Milestone

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Feb 5, 2024

Dependency

  • pages/guides.html is in published

Note: when the above dependency is satisfied, before prioritizing this issue we must reopen the CodeQL alert on this page: https://github.com/hackforla/website/security/code-scanning/21 and https://github.com/hackforla/website/security/code-scanning/23

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve the "Potentially unsafe external link" alerts which appears in the CodeQL alert 21 and alert 23 by adding the attribute rel="noopener noreferrer"

Action Items

          <a href="{{ item.links.github }}" target="_blank" title="GitHub Profile" class="fa fa-github fa-xl" style="margin-right: 13px; 
          text-decoration: none;"></a>

with

          <a href="{{ item.links.github }}" target="_blank" title="GitHub Profile" class="fa fa-github fa-xl" style="margin-right: 13px; 
          text-decoration: none;" rel="noopener noreferrer"></a>
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. GitHub CodeQL documentation
  2. Webpage: https://www.hackforla.org/guides
  3. This issue is part of Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Code Alerts labels Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

  • Size

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe changed the title Resolve alert 21 and 23 "Potentially unsafe external link" in _layouts/guides.html - GitHub Resolve alert 21 and 23 "Potentially unsafe external link" in pages/guides.html - GitHub Feb 5, 2024
@roslynwythe roslynwythe added size: 0.5pt Can be done in 3 hours or less and removed size: missing labels Feb 5, 2024
@roslynwythe roslynwythe changed the title Resolve alert 21 and 23 "Potentially unsafe external link" in pages/guides.html - GitHub Resolve alert 21 and 23 "Potentially unsafe external link" Feb 5, 2024
@roslynwythe roslynwythe changed the title Resolve alert 21 and 23 "Potentially unsafe external link" Resolve CodeQL alert 21 and 23 "Potentially unsafe external link" Feb 5, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the 02. Security milestone Feb 8, 2024
@t-will-gillis
Copy link
Member

t-will-gillis commented Jun 17, 2024

@kgold2018
Copy link
Member

CodeQL determined that the alerts attached to the PR were automatically "fixed" after merging:

#6503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Code Alerts manual dependency release role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

4 participants