Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link"

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve CodeQL code alerts 1 - 24 of type Potentially unsafe external link.

Dependencies (child issues - this issue will remain open until all these issues are completed)

• Resolve CodeQL alert 1 "Potentially unsafe external link" #5673
• Resolve CodeQL alert 4 "Potentially unsafe external link #5674
• Resolve CodeQL alert 9 "Potentially unsafe external link" #6043
• Resolve CodeQL alert 5 and 7 "Potentially unsafe external link" #6226
• Resolve CodeQL alert 6 and 8 "Potentially unsafe external link"  #6227
• Resolve CodeQL alert 3 "Potentially unsafe external link" #6044
• Resolve CodeQL alert 10 "Potentially unsafe external link" #6045
• Resolve CodeQL alert 11 "Potentially unsafe external link" #6046
• Resolve CodeQL alert 13 "Potentially unsafe external link" #6047
• Resolve CodeQL alert 14 "Potentially unsafe external link" #6048
• Resolve CodeQL alert 15 "Potentially unsafe external link" #6049
• Resolve CodeQL alert 16 "Potentially unsafe external link" #6050
• Resolve CodeQL alert 17 "Potentially unsafe external link" #6051
• Resolve CodeQL alert 18 "Potentially unsafe external link" #6052
• Resolve CodeQL alert 19 "Potentially unsafe external link" #6053
• Resolve CodeQL alert 20 "Potentially unsafe external link" #6054
• Resolve CodeQL alert 21 and 23 "Potentially unsafe external link" #6230
• Resolve CodeQL alert 22 and 24 "Potentially unsafe external link"  #6231
• Resolve CodeQL alert 98 "Potentially unsafe external link" #6309

These address instances which were not flagged by CodeQL:

• Resolve Potentially unsafe external link (1) not flagged in about-card-sponsors.html
• Resolve Potentially unsafe external link (2) not flagged in about-card-sponsors.html
• Resolve Potentially unsafe external link (3) not flagged in about-card-sponsors.html
• Resolve "Potentially unsafe external link" in _includes/current-guides.html #6484

Action Items

• Determine whether to dismiss the alerts or to update the code
• Develop a template for issues that will update the code to resolve the alerts see Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129 (comment)
• create sample issue - Resolve CodeQL alert 1 "Potentially unsafe external link" #5673
• For each alert listed above, create an issue using this template
• Once each issue is created, replace the text above with a link to the issue
• Create issues to handle three additional links in includes/about-page/about-card-sponsors.html that use target=_blank that are not flagged by CodeQL. Modify the template as needed.

Issue Template

[HackforLABot]

@roslynwythe

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Tuesday, October 8, 2024 at 12:05 AM PST.}

[HackforLABot]

@roslynwythe

Please add update using the below template (even if you have a pull request). Afterwards, remove the '2 weeks inactive' label and add the 'Status: Updated' label.

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Tuesday, October 15, 2024 at 12:04 AM PST.}