Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL alert 6 and 8 "Potentially unsafe external link" #6227

Closed
7 tasks done
Tracked by #5129
roslynwythe opened this issue Feb 4, 2024 · 3 comments · Fixed by #6324
Closed
7 tasks done
Tracked by #5129

Resolve CodeQL alert 6 and 8 "Potentially unsafe external link" #6227

roslynwythe opened this issue Feb 4, 2024 · 3 comments · Fixed by #6324
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Code Alerts role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Milestone

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Feb 4, 2024

Dependency

  • _layouts/guides.html is in production (specified in _config.yml)

Note: when the above dependency is satisfied, before prioritizing this issue we must reopen the CodeQL alert on this page: https://github.com/hackforla/website/security/code-scanning/6 and https://github.com/hackforla/website/security/code-scanning/8

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We need to resolve the alert "Potentially unsafe external link" which appears in the CodeQL alert 6 and alert 8 by adding the attribute rel="noopener noreferrer"

Action Items

  • The following item is required for GitHub to establish tracking between this issue and the alert. No action is required. You may simply check the checkbox. If you do follow the link to learn more about CodeQL alerts, DO NOT DISMISS THE ALERT.
  • https://github.com/hackforla/website/security/code-scanning/6
  • Open the file _layouts/guides.html in your IDE
  • Replace BOTH instances of:
<a href="{{ item.links.linked-in }}" target="_blank" title="Linkedin Profile" class="fa fa-linkedin fa-xl" style="margin-right: 13px;
text-decoration: none;"></a>

with

<a href="{{ item.links.linked-in }}" target="_blank" title="Linkedin Profile" class="fa fa-linkedin fa-xl" style="margin-right: 13px; 
text-decoration: none;" rel="noopener noreferrer"></a>
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. GitHub CodeQL documentation
  2. Sample webpage using this template: https://www.hackforla.org/guide-pages/2FA
  3. This issue is part of Epic: Create issues to resolve CodeQL alerts 1- 24, 98 "Potentially unsafe external link" #5129
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:

  • Complexity, Role, Feature, Size

NOTE: Please ignore this comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Dependency An issue is blocking the completion or starting of another issue size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Code Alerts and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Feb 4, 2024
@roslynwythe roslynwythe changed the title Resolve alert 6 "Potentially unsafe external link" in _layouts/guides.html - GitHub Resolve alert 6and 8 "Potentially unsafe external link" in _layouts/guides.html - LinkedIn Feb 5, 2024
@roslynwythe roslynwythe changed the title Resolve alert 6and 8 "Potentially unsafe external link" in _layouts/guides.html - LinkedIn Resolve alert 6 and 8 "Potentially unsafe external link" in _layouts/guides.html - LinkedIn Feb 5, 2024
@roslynwythe roslynwythe added Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less and removed good first issue Good for newcomers size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 5, 2024
@roslynwythe roslynwythe changed the title Resolve alert 6 and 8 "Potentially unsafe external link" in _layouts/guides.html - LinkedIn Resolve alert 6 and 8 "Potentially unsafe external link" Feb 5, 2024
@roslynwythe roslynwythe changed the title Resolve alert 6 and 8 "Potentially unsafe external link" Resolve CodeQL alert 6 and 8 "Potentially unsafe external link" Feb 5, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the 02. Security milestone Feb 8, 2024
@SteeRevo SteeRevo self-assigned this Feb 20, 2024
Copy link

Hi @SteeRevo, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@SteeRevo
Copy link
Member

Availability for this week: Weekdays, 8pm-9:30pm
My estimated ETA for completing this issue: 2/21

@ExperimentsInHonesty ExperimentsInHonesty removed the Dependency An issue is blocking the completion or starting of another issue label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Code Alerts role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

3 participants