Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved CodeQL Alerts 6 and 8 #6324

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

SteeRevo
Copy link
Member

Fixes #6227

What changes did you make?

-added the attribute rel="noopener noreferrer" to both instances of <a href="{{ item.links.linked-in }}" target="_blank" title="Linkedin Profile" class="fa fa-linkedin fa-xl" style="margin-right: 13px; text-decoration: none;"></a>

Why did you make the changes (we will use this info to test)?

  • To prevent the alert "Potentially unsafe external link" from appearing in CodeQL

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Changed lines in _/layouts/guides.html file. No visual changes to website

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b SteeRevo-resolve-codeql-alert-6227 gh-pages
git pull https://github.com/SteeRevo/website.git resolve-codeql-alert-6227

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/SteeRevo/website/blob/resolve-codeql-alert-6227/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Dependency An issue is blocking the completion or starting of another issue Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less Feature: Code Alerts labels Feb 20, 2024
@gaylem gaylem requested review from gaylem and abenipa3 and removed request for gaylem February 20, 2024 17:29
@gaylem
Copy link
Member

gaylem commented Feb 20, 2024

Sorry @abenipa3, I accidentally removed you from the reviewers when I tried to add myself. Managed to get you back on here, though! Let me know if this caused any issues for you.

Copy link
Member

@gaylem gaylem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @SteeRevo!

  • Your branch is correct
  • The issue is correctly linked from your PR
  • You made the appropriate changes to the correct lines
  • Your PR clearly states the changes you made

Approved! Great work and thanks again :)

@gaylem
Copy link
Member

gaylem commented Feb 20, 2024

Availability: Weekdays 10AM - 8PM CST
ETA for review: 2024-02-20

@Thinking-Panda
Copy link
Member

@abenipa3 Whenever possible, Please update your availability and review ETA for this PR.

@abenipa3
Copy link
Member

abenipa3 commented Feb 20, 2024

@Thinking-Panda @gaylem Hi there, sorry I just read the notifications of this PR - I took a quick glance at this PR and read that this is for the guide-pages based on the description and the code change?

I haven't been active in HfLA for almost two years as I've been working full-time so I'm not sure if I'm suited to review this as I've been out of the loop since summer 2022 🙇

If you have any questions relating to what I've done re: guide pages in the past or if I should be informed of something related that requires my review, please let me know (as I was not aware of this PR and the issue linked in the description till now).

P.S. Looks good/makes sense to me (from reading the changes only though) 👍 I'm happy to see further improvements are being made on the guide pages, too 😄

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SteeRevo - Great work! Your branches are correct, you are linked back to the issue, you have provided a concise description of what you did and why, and you note that there are no visual changes.

Your code changes address both CodeQL alerts 6 and 8.

Thanks for addressing these two "Potentially unsafe external link" alerts!

@t-will-gillis
Copy link
Member

Hey @abenipa3 welcome back! Please message me on Slack when convenient. Thanks!

@t-will-gillis t-will-gillis merged commit c447e4e into hackforla:gh-pages Feb 21, 2024
10 checks passed
@abenipa3
Copy link
Member

abenipa3 commented Feb 21, 2024

Hi @t-will-gillis, I think there's a misunderstanding here.

I apologize if I wasn't clear earlier and for continuing the conversation here as I no longer have a Slack account in HfLA's space.

I'm not sure if I was tagged to review this PR by mistake; I had mentioned earlier I was not aware of this PR and the issue tied to it.

I also had mentioned that I haven't been able to contribute to HfLA since 2022 and won't be able to continue to do.

If there's any further comments or questions, I am reachable via email at abenipa3@gmail.com. Thanks

@gaylem gaylem removed the request for review from abenipa3 February 21, 2024 06:28
@gaylem
Copy link
Member

gaylem commented Feb 21, 2024

Hey @abenipa3 that was probably my mistake. As I said in my previous comment, I accidentally removed a reviewer, and when I went to try to add them back your name was the first to come up as a suggestion from Github. I went ahead and removed you. Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Code Alerts role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 6 and 8 "Potentially unsafe external link"
5 participants