Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GitHub wins action #1100

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

akibrhast
Copy link
Member

@akibrhast akibrhast commented Feb 24, 2021

Fixes #1069

Merging this pull request will result in:

  1. A new file called _data/_wins-data.json
  2. A new GitHub action which creates the file mentioned in 2. under .github/workflow/_wins-data.yml

Info

Example json file that is generated can be currently found here
https://github.com/akibrhast/github-actions-test/blob/master/_data/_wins-data.json

@akibrhast akibrhast requested a review from cnk February 24, 2021 05:08
@akibrhast
Copy link
Member Author

This is what the new data looks like

image

Copy link
Member

@jbubar jbubar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge. @akibrhast demo'ed it for us a a few days ago, and it works fabulously, and this is not yet hooked up to anything on the page, so nothing will break

@martham0
Copy link
Member

martham0 commented Mar 3, 2021

Everything looks good!

@martham0 martham0 merged commit 32b1b92 into hackforla:gh-pages Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new github action that will eventually replace the wins page github action
3 participants