Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communities of Practice page (in progress) #1137

Closed

Conversation

dmcneary
Copy link
Member

Checking in my work so far for @ruqpyL2 to take over

@dmcneary dmcneary linked an issue Feb 28, 2021 that may be closed by this pull request
16 tasks
@dmcneary dmcneary marked this pull request as draft February 28, 2021 19:25
@csseu csseu marked this pull request as ready for review March 17, 2021 16:26
@csseu
Copy link
Contributor

csseu commented Mar 17, 2021

Following @cnk suggestion and the blurb that says Add more commits by pushing to the create-CommOfPractice-page branch on dmcneary/website, I think I
pushed my commits to dmcneary#2

Does that work for everyone? @dmcneary @jbubar @drubgrubby Let me know if I need to put it somewhere else.

@jbubar
Copy link
Member

jbubar commented Mar 17, 2021

Following @cnk suggestion and the blurb that says Add more commits by pushing to the create-CommOfPractice-page branch on dmcneary/website, I think I
pushed my commits to dmcneary#2

Does that work for everyone? @dmcneary @jbubar @drubgrubby Let me know if I need to put it somewhere else.

I think you can just create a new pr directly to hackforla:gh-pages
I think that merging it to davids can cause some complications that might be confusing to deal with.

Just go to your feature branch and push it to your fork of the repo, and create a new pr

git push origin create-CommOfPractice-page

@akibrhast
Copy link
Member

Since @ruqpyL2 has opened a separate PR(#1250) which I believe builds on top of this PR. I am now closing this PR.

@akibrhast akibrhast closed this Mar 18, 2021
@csseu csseu removed a link to an issue Mar 18, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants