Wins page modal a11y #1679

grhhhh · 2021-06-01T23:27:45Z

-Makes "see more..." tab-able.
-Makes modal close when ESC key is pressed.
-Captures focus so that modal content is tab-able and background content is ignored while the modal is open.

Note: this fix requires the use of the inert polyfill

Aveline-art · 2021-06-05T02:33:50Z

@grhhhh I can't seem to tab-focus inside the modal. Am I doing it right? This is what I have tried.

Click 'see more' to open modal.
Press tab.
Tab scrolls focus over 'linkedin' and 'github' links.

Am I supposed to tab when the state of the page is like this?

For specs, I use the latest version of Firefox on Windows.

grhhhh · 2021-06-05T21:47:56Z

@Aveline-art can you be specific regarding which 'linkedin' and 'github' links are focused by tab as you described? Specifically whether tab focuses on the links inside of the modal or outside of it.

The intended function and the functionality that I observed (macbook pro, chrome) is that tab focuses on the modal content, in this case the 'linkedin' and 'github' links, while ignoring all things outside of the modal.

Aveline-art · 2021-06-05T22:38:14Z

@grhhhh Sorry for not being more clear. To clarify: when I press tab, the focus scrolls to the links inside the modal. Once those options are exhausted, the focus returns to behind the modal. At a certain point the focus cycles back to the modal, before continuing behind the modal, and so on and so on.

pages/wins/wins.html

_sass/components/_wins-page.scss

grhhhh · 2021-06-09T00:41:18Z

@akibrhast
Latest commit removes package-lock.json and commented code as requested. Also, inert.min.js was added to js/assets directory and linked in wins.html

@Aveline-art
I was unable to recreate the issues you described using the latest version of Firefox on my machine.

Aveline-art

Update June 8th, 2021. I have discovered an error on my end that was causing the problems. @grhhhh Everything is good. Great job on this!

akibrhast · 2021-06-10T14:07:09Z

@grhhhh Hey, were you able to resolve that issue in regards to the see more, see less button that occurs at a certain screen width.... ?

grhhhh · 2021-06-10T21:50:35Z

A bug was discovered while working on this issue: the ‘see more’ link changes to read ‘see less’ when opened, but does not change back to ‘see more’ after being closed. A fix falls outside of the scope of this PR.

akibrhast

lgtm

This reverts commit c122699.

This reverts commit c492445.

* makes ESC key close wins page modal * progress toward mwins page modal fix * in progress * fixes issue w hideoverly and inert * removes package-lock.json and commented code * fixes bug where inert remained true after window resize < 960 * fixes inert bug

This reverts commit c122699.

…" (hackforla#1747) This reverts commit c492445.

* Changed margin for toolkit page header (#1726) * Updating wins data * Update meeting data * Update contributor and language data * Wins page modal a11y (#1679) * makes ESC key close wins page modal * progress toward mwins page modal fix * in progress * fixes issue w hideoverly and inert * removes package-lock.json and commented code * fixes bug where inert remained true after window resize < 960 * fixes inert bug * Revert "Wins page modal a11y (#1679)" (#1738) This reverts commit c122699. * Updating wins data * Update meeting data * Update contributor and language data * revert wins-data.json (#1745) * Updating wins data * need to delete this, this check is in the app sheet, plus it is breaking the page (#1746) * Update program areas page to reflect correct mini project cards (#1684) * Updates program areas to reflect correct project cards * Add placeholder image to repo and update on corresponding cards * Revert "Revert "Wins page modal a11y (#1679)" (#1738)" (#1747) This reverts commit c492445. * Wins form css (#1314) * begin css changes * initial page styling * add submit success message * styled the inputs to be more simple * small update * change colors to variables * fix github error checking, and make textarea required * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Updating wins data * Update meeting data * Update contributor and language data * Create add-issue-labels-to-pr.yml (#1740) * Create add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Added auth. To be reverted. * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update CONTRIBUTING.md (#1751) * Update update-comment-on-update-label.yml Fix typo * Create pull_request_template.md * Delete pull_request_template.md * Create pull_request_template.md * Update pull_request_template.md * Update pull_request_template.md * Fixes #1574 (#1764) * Update people2.yml (#1763) * Update meeting data * Update contributor and language data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Change Alt Text for Delegate Icon on Credit page (#1771) * Fixes #1574 * Change Alt Text for Delegate Icon on Credit page * change resume alt to resume icon (#1765) * Update comment on gh action add-issue-labels-to-pr (#1758) The comments added to the action clarifies and notes the decision behind the usage of the event `pull_request_target` instead of `pull_request` * Contributing.md changes (#1471) * Got Akibs Changes * Update CONTRIBUTING.md file * Accepted incoming merge conflict * Made github username wording more consistent * Added documentation for using Docker back to the file * Added git status code back to file * Changed edits to pull request * Changed wording of issue and pull request headers * Fixed broken link in edits to a pull request * Changed wording of first pull request in bottom greeting * Removed unnecessary text * Added info about VS Code and moved Changes from Upsream section * Added hfla-site slack link * Made changes suggested by alyssa * Update CONTRIBUTING.md Minor changes. Made two changes to the file. Co-authored-by: Josh Bubar <53061723+jbubar@users.noreply.github.com> Co-authored-by: Alyssa <38295612+alyssabenipayo@users.noreply.github.com> * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Changed the alt attribute value to 'Design Community Concept Illustration' for the Design Image on the Credit Page (#1780) Co-authored-by: Mateo Godoy <mgodoy@berkeley.edu> * 1586 - update alt itext for "Technology" image within the "Credits" page (#1784) * Updating wins data * Update meeting data * Update contributor and language data * Adjusts Program Areas page image cards in mobile (#1774) * Adjusts Program Areas page image cards in mobile * Updates height of card image to correct size * Updating wins data * Update meeting data * Update contributor and language data * Change alt text (#1782) * changed alt text for Partnership Icon on Credit page (#1783) * Updating wins data * Update meeting data * Update contributor and language data * changed alt office worker (#1804) * changed alt text for designer life image on credits page (#1801) * add missing periods in the Getting Started Page (#1799) * remove margin: auto to split header paragraphs (#1790) * Adding button xl-long class and applying it to CTA "Join Us" home page button (#1773) * Testing * New home button * Removed test * New Classes * removed} * } * removed accidental changes Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> * 1792 - add HTML/CSS to ensure "Online Project Team Meetings" button wraps text within the mobile view of the "Events" page (#1813) * Standardize join us page mobile (#1731) * added title attibutes to sponsor and partner logos in about pages * Changed "vertical" to "program area" * standardized join us page on mobile * media queries changed and header name change * text-align left added to mobile & header container added Co-authored-by: Linda-OC <67043889+Linda-OC@users.noreply.github.com> Co-authored-by: avali4907 <avali4907@outlook.com> * Updating wins data * Update meeting data * Update contributor and language data * Rename security.yml (#1821) * issue 1570, change email alt text (#1827) * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Create Responsiveness on mobile * Rename Responsiveness on mobile to Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update issue templates * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Update Toolkit page's filter banner font weight (#1831) * Fixes #1574 * Change Alt Text for Delegate Icon on Credit page * changed toolkit banner font to 400 * Revert "changed toolkit banner font to 400" This reverts commit 7c24302. * Revert "Revert "changed toolkit banner font to 400"" This reverts commit b4b1c83. * Added documentation for unseen changes (#1854) * Added documentation for fixing jekyll livereloading bug * Fixed some typos * Moved location of changes * removed max height property so all getting started cards were visible (#1853) * Add x modal wins page (#1775) * Added x to modal in wins page to exit * Styled x closing icon to fit in upper right corner of modal * Used svg icon to show close icon on modal in wins page * Implementing new design system heading typography in the code base (#1814) * New typography * removed { * removes } * Added , * Update _typography.scss * Update _typography.scss * Update _typography.scss * Update _print.scss * Update _typography.scss * Update _typography.scss * Fixed title1 print Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> * Updating wins data * Update meeting data * Update contributor and language data * Add media query to .leader-description (#1855) * Update credits.html * Clarified adding images * Update pull_request_template.md * 1748, closed pr 1832, attempt 2 (#1858) * 1748, closed pr 1832, attempt 2 * 1858 pr update * change alt for video conference icon (#1860) * changed alt attribute for meetings icon on credit page (#1862) * Updating wins data * Update meeting data * Update contributor and language data * fix overlay Co-authored-by: Marco Barrera <marcobarrera749@gmail.com> Co-authored-by: HackforLABot <64623632+HackforLABot@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Garrett Hickman <79604590+grhhhh@users.noreply.github.com> Co-authored-by: Akib Rhast <akib.rhast@gmail.com> Co-authored-by: Sarah W <40401149+arghmatey@users.noreply.github.com> Co-authored-by: Zak234 <85966467+Zak234@users.noreply.github.com> Co-authored-by: Ava Li <62368440+Aveline-art@users.noreply.github.com> Co-authored-by: Abel-Zambrano <67209686+Abel-Zambrano@users.noreply.github.com> Co-authored-by: Ali Ibsin <ibsin.a1996@gmail.com> Co-authored-by: Alex Verdin <alexverdin01@gmail.com> Co-authored-by: Alyssa <38295612+alyssabenipayo@users.noreply.github.com> Co-authored-by: mgodoy2023 <86011089+mgodoy2023@users.noreply.github.com> Co-authored-by: Mateo Godoy <mgodoy@berkeley.edu> Co-authored-by: Adam Abundis <adamjabundis@gmail.com> Co-authored-by: Vicki Chung <72854605+vickiychung@users.noreply.github.com> Co-authored-by: benrempel <benrempel93@gmail.com> Co-authored-by: Marianna Askova <74923247+MariannaAskova@users.noreply.github.com> Co-authored-by: Andrew Lieu <andrewalieu@gmail.com> Co-authored-by: Alexey Sergeev <xengawe@gmail.com> Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> Co-authored-by: Josephine Han <63170710+josiehandeveloper@users.noreply.github.com> Co-authored-by: Linda-OC <67043889+Linda-OC@users.noreply.github.com> Co-authored-by: avali4907 <avali4907@outlook.com> Co-authored-by: Sophia Ling <86015625+anonymousanemone@users.noreply.github.com> Co-authored-by: Sihemgourou <55627107+Sihemgourou@users.noreply.github.com> Co-authored-by: macho-catt <48004150+macho-catt@users.noreply.github.com>

* New wins text badge (#1466) * edited js * edited html * edited scss * added all svgs * all changes added minus one Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com> * New wins change (#1516) * overlay and styling * mobile styling * see more toggle * adjusted styling, issues with onClick function * badges are clickable on mobile * badge icon click hooked up to seeMore * design edits + see more functionality edit Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com> * filtered unintended commas out of cardList (#1601) * Adjust styling of Wins page with badges in mobile Fixes #1550 Changed from 1.7em to 1.4em and 1.5em to 1em * Revert "Adjust styling of Wins page with badges in mobile" (#1641) This reverts commit 9fc22fb. * Adjust styling wins (#1620) * adjust styling of Wins page with badges * charge roles wrap * revert wins-data.json * Changed badge description from setup to set up in wins page (#1785) * adjusted.wins-badge-icon size for mobile 1.4em when card is collapsed, 1em when expanded (#1670) * 1817 - remove "I setup 2FA" from wins-data.json and refactored icon parser in wins.html (#1883) * Fixed wins modal position to prevent it from penetrating menu in mobile (#1897) * Add github actions files to wins branch (#1905) * Revert "Add github actions files to wins branch (#1905)" (#1925) This reverts commit b6d4c09. * see more <-> see less on wins page mobile view (#1924) * [qiqicodes-1549-see-less-button-wins-pages] toggle see more/see less functionality * [qiqicodes-1549-see-less-button-wins-pages] adds caret svg * [qiqicodes-1549-see-less-button-wins-pages] toggle see more/see less for wins card * [qiqicodes-1549-see-less-button-wins-pages] delete commented lines of old code * [qiqicodes-1549-see-less-button-wins-pages] see more/see less styling * change position of see more in mobile, and clean up code * make placement on expansion work * move see more to bottom of text, and see less to bottom of card in mobile * delete console.log * remove commented code Co-authored-by: qiqicodes <qiqizheng0127@gmail.com> * updating wins-feature-1 with changes made on gh-pages (#1869) * Changed margin for toolkit page header (#1726) * Updating wins data * Update meeting data * Update contributor and language data * Wins page modal a11y (#1679) * makes ESC key close wins page modal * progress toward mwins page modal fix * in progress * fixes issue w hideoverly and inert * removes package-lock.json and commented code * fixes bug where inert remained true after window resize < 960 * fixes inert bug * Revert "Wins page modal a11y (#1679)" (#1738) This reverts commit c122699. * Updating wins data * Update meeting data * Update contributor and language data * revert wins-data.json (#1745) * Updating wins data * need to delete this, this check is in the app sheet, plus it is breaking the page (#1746) * Update program areas page to reflect correct mini project cards (#1684) * Updates program areas to reflect correct project cards * Add placeholder image to repo and update on corresponding cards * Revert "Revert "Wins page modal a11y (#1679)" (#1738)" (#1747) This reverts commit c492445. * Wins form css (#1314) * begin css changes * initial page styling * add submit success message * styled the inputs to be more simple * small update * change colors to variables * fix github error checking, and make textarea required * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Updating wins data * Update meeting data * Update contributor and language data * Create add-issue-labels-to-pr.yml (#1740) * Create add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Added auth. To be reverted. * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update add-issue-labels-to-pr.yml * Update CONTRIBUTING.md (#1751) * Update update-comment-on-update-label.yml Fix typo * Create pull_request_template.md * Delete pull_request_template.md * Create pull_request_template.md * Update pull_request_template.md * Update pull_request_template.md * Fixes #1574 (#1764) * Update people2.yml (#1763) * Update meeting data * Update contributor and language data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Change Alt Text for Delegate Icon on Credit page (#1771) * Fixes #1574 * Change Alt Text for Delegate Icon on Credit page * change resume alt to resume icon (#1765) * Update comment on gh action add-issue-labels-to-pr (#1758) The comments added to the action clarifies and notes the decision behind the usage of the event `pull_request_target` instead of `pull_request` * Contributing.md changes (#1471) * Got Akibs Changes * Update CONTRIBUTING.md file * Accepted incoming merge conflict * Made github username wording more consistent * Added documentation for using Docker back to the file * Added git status code back to file * Changed edits to pull request * Changed wording of issue and pull request headers * Fixed broken link in edits to a pull request * Changed wording of first pull request in bottom greeting * Removed unnecessary text * Added info about VS Code and moved Changes from Upsream section * Added hfla-site slack link * Made changes suggested by alyssa * Update CONTRIBUTING.md Minor changes. Made two changes to the file. Co-authored-by: Josh Bubar <53061723+jbubar@users.noreply.github.com> Co-authored-by: Alyssa <38295612+alyssabenipayo@users.noreply.github.com> * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Changed the alt attribute value to 'Design Community Concept Illustration' for the Design Image on the Credit Page (#1780) Co-authored-by: Mateo Godoy <mgodoy@berkeley.edu> * 1586 - update alt itext for "Technology" image within the "Credits" page (#1784) * Updating wins data * Update meeting data * Update contributor and language data * Adjusts Program Areas page image cards in mobile (#1774) * Adjusts Program Areas page image cards in mobile * Updates height of card image to correct size * Updating wins data * Update meeting data * Update contributor and language data * Change alt text (#1782) * changed alt text for Partnership Icon on Credit page (#1783) * Updating wins data * Update meeting data * Update contributor and language data * changed alt office worker (#1804) * changed alt text for designer life image on credits page (#1801) * add missing periods in the Getting Started Page (#1799) * remove margin: auto to split header paragraphs (#1790) * Adding button xl-long class and applying it to CTA "Join Us" home page button (#1773) * Testing * New home button * Removed test * New Classes * removed} * } * removed accidental changes Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> * 1792 - add HTML/CSS to ensure "Online Project Team Meetings" button wraps text within the mobile view of the "Events" page (#1813) * Standardize join us page mobile (#1731) * added title attibutes to sponsor and partner logos in about pages * Changed "vertical" to "program area" * standardized join us page on mobile * media queries changed and header name change * text-align left added to mobile & header container added Co-authored-by: Linda-OC <67043889+Linda-OC@users.noreply.github.com> Co-authored-by: avali4907 <avali4907@outlook.com> * Updating wins data * Update meeting data * Update contributor and language data * Rename security.yml (#1821) * issue 1570, change email alt text (#1827) * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Create Responsiveness on mobile * Rename Responsiveness on mobile to Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update Mobile_responsiveness.md * Update issue templates * Updating wins data * Update meeting data * Update contributor and language data * Updating wins data * Update meeting data * Update contributor and language data * Update Toolkit page's filter banner font weight (#1831) * Fixes #1574 * Change Alt Text for Delegate Icon on Credit page * changed toolkit banner font to 400 * Revert "changed toolkit banner font to 400" This reverts commit 7c24302. * Revert "Revert "changed toolkit banner font to 400"" This reverts commit b4b1c83. * Added documentation for unseen changes (#1854) * Added documentation for fixing jekyll livereloading bug * Fixed some typos * Moved location of changes * removed max height property so all getting started cards were visible (#1853) * Add x modal wins page (#1775) * Added x to modal in wins page to exit * Styled x closing icon to fit in upper right corner of modal * Used svg icon to show close icon on modal in wins page * Implementing new design system heading typography in the code base (#1814) * New typography * removed { * removes } * Added , * Update _typography.scss * Update _typography.scss * Update _typography.scss * Update _print.scss * Update _typography.scss * Update _typography.scss * Fixed title1 print Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> * Updating wins data * Update meeting data * Update contributor and language data * Add media query to .leader-description (#1855) * Update credits.html * Clarified adding images * Update pull_request_template.md * 1748, closed pr 1832, attempt 2 (#1858) * 1748, closed pr 1832, attempt 2 * 1858 pr update * change alt for video conference icon (#1860) * changed alt attribute for meetings icon on credit page (#1862) * Updating wins data * Update meeting data * Update contributor and language data * fix overlay Co-authored-by: Marco Barrera <marcobarrera749@gmail.com> Co-authored-by: HackforLABot <64623632+HackforLABot@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Garrett Hickman <79604590+grhhhh@users.noreply.github.com> Co-authored-by: Akib Rhast <akib.rhast@gmail.com> Co-authored-by: Sarah W <40401149+arghmatey@users.noreply.github.com> Co-authored-by: Zak234 <85966467+Zak234@users.noreply.github.com> Co-authored-by: Ava Li <62368440+Aveline-art@users.noreply.github.com> Co-authored-by: Abel-Zambrano <67209686+Abel-Zambrano@users.noreply.github.com> Co-authored-by: Ali Ibsin <ibsin.a1996@gmail.com> Co-authored-by: Alex Verdin <alexverdin01@gmail.com> Co-authored-by: Alyssa <38295612+alyssabenipayo@users.noreply.github.com> Co-authored-by: mgodoy2023 <86011089+mgodoy2023@users.noreply.github.com> Co-authored-by: Mateo Godoy <mgodoy@berkeley.edu> Co-authored-by: Adam Abundis <adamjabundis@gmail.com> Co-authored-by: Vicki Chung <72854605+vickiychung@users.noreply.github.com> Co-authored-by: benrempel <benrempel93@gmail.com> Co-authored-by: Marianna Askova <74923247+MariannaAskova@users.noreply.github.com> Co-authored-by: Andrew Lieu <andrewalieu@gmail.com> Co-authored-by: Alexey Sergeev <xengawe@gmail.com> Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> Co-authored-by: Josephine Han <63170710+josiehandeveloper@users.noreply.github.com> Co-authored-by: Linda-OC <67043889+Linda-OC@users.noreply.github.com> Co-authored-by: avali4907 <avali4907@outlook.com> Co-authored-by: Sophia Ling <86015625+anonymousanemone@users.noreply.github.com> Co-authored-by: Sihemgourou <55627107+Sihemgourou@users.noreply.github.com> Co-authored-by: macho-catt <48004150+macho-catt@users.noreply.github.com> * Add github actions files to wins branch (#1926) * Fix to mobile margin on Wins page (#1936) * Changed margin to 32px * reversed back the main margin and changed only the margin for mobile * remove tablet view and fix responsiveness issues (#1954) * remove tablet view and fix responsiveness issues * make icons clickable in mobile * remove clickable icons in desktop * quick fix to remove see less on desktop * better fix for removing see less on desktop * fix the unclickability issue on the see more after resize * fix overlay other icon parser problem * clean up * make icons unclickable when expanded * delete console log * Wins Spacing, between text and badge icons #1551 (#1964) * fixes spacing between wins-text and wins-badges * clean up * more spacing added * spacing * resolved Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com> Co-authored-by: Josh Bubar <53061723+jbubar@users.noreply.github.com> * Wins refactor js (#2019) * Clarified comments, Change functions to arrow functions and removed extra spaces * Revert "Clarified comments, Change functions to arrow functions and removed extra spaces" This reverts commit 7bf6086. * Clarified comments, changed function into arrow function and removed extra spaces * removed spacing in functions Co-authored-by: avali4907 <avali4907@outlook.com> * Fix see more toggle when clicking an icon (#2133) * more merge conflicts * remove json data files from pr * Add accompanying map file for polyfill (#2144) * merge conflicts * Add title1 class to h1 tag in wins hero file (#2189) Co-authored-by: erikaBell <67438372+erikaBell@users.noreply.github.com> Co-authored-by: erikaBell <67438372+erikaBelll@users.noreply.github.com> Co-authored-by: James Berke <58538332+jamesberke@users.noreply.github.com> Co-authored-by: Linda-OC <67043889+Linda-OC@users.noreply.github.com> Co-authored-by: Alex Verdin <alexverdin01@gmail.com> Co-authored-by: wendywilhelm10 <44912633+wendywilhelm10@users.noreply.github.com> Co-authored-by: Akib Mohaimenur Rahman <akib.rhast@gmail.com> Co-authored-by: Marco Barrera <marcobarrera749@gmail.com> Co-authored-by: Adam Abundis <adamjabundis@gmail.com> Co-authored-by: Ava Li <62368440+Aveline-art@users.noreply.github.com> Co-authored-by: qiqicodes <qiqizheng0127@gmail.com> Co-authored-by: HackforLABot <64623632+HackforLABot@users.noreply.github.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Garrett Hickman <79604590+grhhhh@users.noreply.github.com> Co-authored-by: Sarah W <40401149+arghmatey@users.noreply.github.com> Co-authored-by: Zak234 <85966467+Zak234@users.noreply.github.com> Co-authored-by: Abel-Zambrano <67209686+Abel-Zambrano@users.noreply.github.com> Co-authored-by: Ali Ibsin <ibsin.a1996@gmail.com> Co-authored-by: Alyssa <38295612+alyssabenipayo@users.noreply.github.com> Co-authored-by: mgodoy2023 <86011089+mgodoy2023@users.noreply.github.com> Co-authored-by: Mateo Godoy <mgodoy@berkeley.edu> Co-authored-by: Vicki Chung <72854605+vickiychung@users.noreply.github.com> Co-authored-by: benrempel <benrempel93@gmail.com> Co-authored-by: Marianna Askova <74923247+MariannaAskova@users.noreply.github.com> Co-authored-by: Andrew Lieu <andrewalieu@gmail.com> Co-authored-by: Alexey Sergeev <xengawe@gmail.com> Co-authored-by: Sakari Salminiitty <sakarisalminiitty@Sakaris-MacBook-Air.local> Co-authored-by: Josephine Han <63170710+josiehandeveloper@users.noreply.github.com> Co-authored-by: avali4907 <avali4907@outlook.com> Co-authored-by: Sophia Ling <86015625+anonymousanemone@users.noreply.github.com> Co-authored-by: Sihemgourou <55627107+Sihemgourou@users.noreply.github.com> Co-authored-by: macho-catt <48004150+macho-catt@users.noreply.github.com> Co-authored-by: Adrian Zaragoza <77212035+adrian-zaragoza@users.noreply.github.com>

grhhhh added 4 commits May 15, 2021 16:37

makes ESC key close wins page modal

dd75b6b

progress toward mwins page modal fix

3225781

in progress

fbd161a

fixes issue w hideoverly and inert

5c9f9bd

grhhhh marked this pull request as ready for review June 1, 2021 23:31

grhhhh requested a review from akibrhast June 1, 2021 23:31

jbubar requested review from Aveline-art and jamesberke June 2, 2021 02:45

akibrhast suggested changes Jun 6, 2021

View reviewed changes

pages/wins/wins.html Outdated Show resolved Hide resolved

pages/wins/wins.html Outdated Show resolved Hide resolved

pages/wins/wins.html Outdated Show resolved Hide resolved

_sass/components/_wins-page.scss Outdated Show resolved Hide resolved

removes package-lock.json and commented code

0d5e7de

Aveline-art approved these changes Jun 9, 2021

View reviewed changes

akibrhast self-requested a review June 10, 2021 02:02

grhhhh added 2 commits June 10, 2021 18:23

fixes bug where inert remained true after window resize < 960

46625d0

fixes inert bug

c4083c2

Sihemgourou mentioned this pull request Jun 12, 2021

adjusted icon size for mobile - 1.4em collapsed, 1em expanded #1670

Merged

akibrhast approved these changes Jun 15, 2021

View reviewed changes

akibrhast merged commit c122699 into hackforla:gh-pages Jun 15, 2021

akibrhast added a commit that referenced this pull request Jun 15, 2021

Revert "Wins page modal a11y (#1679)"

5b43501

This reverts commit c122699.

akibrhast mentioned this pull request Jun 15, 2021

Revert "Wins page modal a11y" #1738

Merged

akibrhast added a commit that referenced this pull request Jun 15, 2021

Revert "Wins page modal a11y (#1679)" (#1738)

c492445

This reverts commit c122699.

akibrhast added a commit that referenced this pull request Jun 16, 2021

Revert "Revert "Wins page modal a11y (#1679)" (#1738)"

7155d63

This reverts commit c492445.

akibrhast added a commit that referenced this pull request Jun 16, 2021

Revert "Revert "Wins page modal a11y (#1679)" (#1738)" (#1747)

aedbca2

This reverts commit c492445.

codessi pushed a commit to codessi/website-1 that referenced this pull request Jun 21, 2021

Revert "Wins page modal a11y (hackforla#1679)" (hackforla#1738)

3cc9949

This reverts commit c122699.

codessi pushed a commit to codessi/website-1 that referenced this pull request Jun 21, 2021

Revert "Revert "Wins page modal a11y (hackforla#1679)" (hackforla#1738)…

a1231c1

…" (hackforla#1747) This reverts commit c492445.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wins page modal a11y #1679

Wins page modal a11y #1679

grhhhh commented Jun 1, 2021

Aveline-art commented Jun 5, 2021

grhhhh commented Jun 5, 2021

Aveline-art commented Jun 5, 2021

grhhhh commented Jun 9, 2021

Aveline-art left a comment

akibrhast commented Jun 10, 2021

grhhhh commented Jun 10, 2021 •

edited

Loading

akibrhast left a comment

Wins page modal a11y #1679

Wins page modal a11y #1679

Conversation

grhhhh commented Jun 1, 2021

Aveline-art commented Jun 5, 2021

grhhhh commented Jun 5, 2021

Aveline-art commented Jun 5, 2021

grhhhh commented Jun 9, 2021

Aveline-art left a comment

Choose a reason for hiding this comment

akibrhast commented Jun 10, 2021

grhhhh commented Jun 10, 2021 • edited Loading

akibrhast left a comment

Choose a reason for hiding this comment

grhhhh commented Jun 10, 2021 •

edited

Loading