Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust location card image height #2149

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Adjust location card image height #2149

merged 1 commit into from
Aug 24, 2021

Conversation

blakes24
Copy link
Member

Fixes #1920

What changes did you make and why did you make them ?

  • Adjusted the location cards' image height for mobile
  • Aligned image so text was still visible in mobile view
  • Adjusted container so images displayed correctly

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Below mobile breakpoint before Screen Shot 2021-08-20 at 11 53 22 AM
Below tablet breakpoint before Screen Shot 2021-08-20 at 1 08 13 PM
Below mobile breakpoint after Screen Shot 2021-08-20 at 11 49 09 AM
Below tablet breakpoint after Screen Shot 2021-08-20 at 1 10 21 PM

@github-actions github-actions bot added Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers Complexity: Medium Test: Update Label To Update ! No update has been provided labels Aug 20, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b blakes24-event-page-cards gh-pages
git pull https://github.com/blakes24/website.git event-page-cards

@abuna1985 abuna1985 requested review from arghmatey and Zak234 August 22, 2021 17:32
@SAUMILDHANKAR SAUMILDHANKAR mentioned this pull request Aug 22, 2021
Open
17 tasks
Zak234
Zak234 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@Zak234 Zak234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arghmatey
arghmatey approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@arghmatey arghmatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @blakes24!

@arghmatey arghmatey merged commit ebda5d5 into hackforla:gh-pages Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arghmatey arghmatey arghmatey approved these changes

@Zak234 Zak234 Zak234 approved these changes

Assignees
No one assigned
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers To Update ! No update has been provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize photo page cards in mobile Events page
4 participants
@blakes24 @arghmatey @Zak234 @Aveline-art