Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the makeIcon function in wins.js file #2267 #2621

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Updated the makeIcon function in wins.js file #2267 #2621

merged 1 commit into from
Dec 27, 2021

Conversation

Johnnie007
Copy link
Contributor

@Johnnie007 Johnnie007 commented Dec 22, 2021 •
edited
Loading

Fixes #2267

What changes did you make and why did you make them ?

-Updated the makeIcon function in wins.js file

  • Added the line of code- icon.setAttribute("target", "_blank");
  • You will have to click on the see more link on an individual wins card. After doing so, the modal view will open. Currently, when you click on the cards Github or LinkedIn Icon. You will be redirected to that user Github or LinkedIn. My solution will open a new tab to the link.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No images to be added

@Johnnie007 Johnnie007 changed the title Updated the makeIcon function in wins.js file 2267 Updated the makeIcon function in wins.js file #2267 Dec 22, 2021
@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Johnnie007-open-new-tab-wins-page gh-pages
git pull https://github.com/Johnnie007/website.git open-new-tab-wins-page

@github-actions github-actions bot added P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers Complexity: Large Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Complexity: Small Take this type of issues after the successful merge of your second good first issue Status: Updated No blockers and update is ready for review and removed role: back end/devOps Tasks for back-end developers Complexity: Large labels Dec 22, 2021
SAUMILDHANKAR
SAUMILDHANKAR approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@SAUMILDHANKAR SAUMILDHANKAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Johnnie007 Thanks for fixing the issue. Changes look good in my environment.

@SAUMILDHANKAR SAUMILDHANKAR merged commit 6bb9e8a into hackforla:gh-pages Dec 27, 2021
@SAUMILDHANKAR SAUMILDHANKAR mentioned this pull request Dec 29, 2021
Open
12 tasks
This was referenced Jan 13, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SAUMILDHANKAR SAUMILDHANKAR SAUMILDHANKAR approved these changes

Assignees
No one assigned
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update profile icons to open in new tab on Wins page
2 participants
@Johnnie007 @SAUMILDHANKAR