Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wins-data.json via Google Apps Script #2765

Closed

Conversation

elizabethhonest
Copy link
Contributor

PR to update the wins data. To be reviewed by the merge team.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b elizabethhonest-update-wins-data gh-pages
git pull https://github.com/elizabethhonest/website.git update-wins-data

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Feb 12, 2022

Not merging this because of the following problems:

In the _wins-data.json and wins-data.json at the end of each Wins entry, there is "":"", which wasn't there in the current _wins-data.json and current wins-data.json in gh-pages. Also, for _wins-data.json, UniqueID shouldn't be there yet because the Google Apps Script related to issue #2385 hasn't been added to the product script.

Also, @SAUMILDHANKAR says there is something wrong with the Wins spreadsheet, where Wins form entry made on 11/5/2021 wasn't added to the Review sheet and so the true/false in the "Display?" and "Homepage?".

@SAUMILDHANKAR will take a look at all the above problems.

@SAUMILDHANKAR
Copy link
Member

Closing this PR as this is not ready to be merged.
Note for future PRs by Elizabeth Honest bot account: #2901 needs to fixed before merging this. Please see the following comment for additional info: Comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants