Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted wins-data.json since we are no longer using AF #3896

Conversation

steven-positive-tran
Copy link
Member

@steven-positive-tran steven-positive-tran commented Jan 30, 2023

Fixes #2148

What changes did you make and why did you make them ?

  • Deleted wins-data.json as this issue is doing step 4 and we are no longer using AF file

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visibile changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b steven-positive-tran-migrate-wins-data-2148 gh-pages
git pull https://github.com/steven-positive-tran/website.git migrate-wins-data-2148

@github-actions github-actions bot added Dependency An issue is blocking the completion or starting of another issue P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less Size: Good second issue labels Jan 30, 2023
@t-will-gillis t-will-gillis self-requested a review January 30, 2023 22:53
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steven-positive-tran - The commit 'from' and 'into' branches are correct and there is the relevant linked issue. The 'Wins' page appears to function as expected on Docker, no unexpected issues with the file deletion. The correct file has been deleted wins-data.json and the file to remain is untouched _wins-data.json. Looks good! Great job.

@d-perez-8 d-perez-8 self-requested a review January 31, 2023 22:16
@d-perez-8
Copy link
Member

ETA: 1 hour
Availability: 2-4pm PST weekdays

Copy link
Member

@d-perez-8 d-perez-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks good, @steven-positive-tran! The issue is completed as instructed and there are no issues with the web page.

@jdingeman
Copy link
Member

Hi @steven-positive-tran, we appreciate you taking up the issue to remove the AF file, however this issue was not supposed to be in the prioritized backlog and its dependency has not been satisfied. It also seems that the dependency's dependency has not been satisfied. Sorry for the confusion. We are going to close this as not planned.

@jdingeman jdingeman closed this Feb 1, 2023
@steven-positive-tran steven-positive-tran deleted the migrate-wins-data-2148 branch February 27, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency An issue is blocking the completion or starting of another issue good first issue Good for newcomers P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Apps Script: Migrate Wins Data - Delete AF file
5 participants