-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted wins-data.json since we are no longer using AF #3896
Deleted wins-data.json since we are no longer using AF #3896
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @steven-positive-tran - The commit 'from' and 'into' branches are correct and there is the relevant linked issue. The 'Wins' page appears to function as expected on Docker, no unexpected issues with the file deletion. The correct file has been deleted wins-data.json
and the file to remain is untouched _wins-data.json
. Looks good! Great job.
ETA: 1 hour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this looks good, @steven-positive-tran! The issue is completed as instructed and there are no issues with the web page.
Hi @steven-positive-tran, we appreciate you taking up the issue to remove the AF file, however this issue was not supposed to be in the prioritized backlog and its dependency has not been satisfied. It also seems that the dependency's dependency has not been satisfied. Sorry for the confusion. We are going to close this as not planned. |
Fixes #2148
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)