Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Project to Website: Tech Work Experience #4911

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Add Project to Website: Tech Work Experience #4911

merged 1 commit into from
Jul 5, 2023

Conversation

adrianang
Copy link
Member

Fixes #2288

What changes did you make?

  • Created new markdown file for the Tech Work Experience Project (tech-work-experience.md)
  • Added assets (project card image, project hero image, PDF overview) to their appropriate folders

Why did you make the changes (we will use this info to test)?

  • To keep list of active HfLA projects on the website up-to-date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied localhost_4000_-before
Visuals after changes are applied localhost_4000_-after (Tech Work Experience comes immediately after Open Community Survey)

localhost_4000_projects_tech-work-experience-project-after

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b adrianang-add-project-to-website-tech-work-exp-2288 gh-pages
git pull https://github.com/adrianang/website.git add-project-to-website-tech-work-exp-2288

@github-actions github-actions bot added Status: Help Wanted Internal assistance is required to make progress role: front end Tasks for front end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less labels Jul 5, 2023
@adrianang adrianang removed Status: Help Wanted Internal assistance is required to make progress ready for dev lead Issues that tech leads or merge team members need to follow up on labels Jul 5, 2023
@Abrosss Abrosss self-requested a review July 5, 2023 16:28
@Abrosss
Copy link
Member

Abrosss commented Jul 5, 2023

Availability: 7/5-6,
ETA: 7/6

@LOSjr4 LOSjr4 self-requested a review July 5, 2023 17:33
LOSjr4
LOSjr4 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@LOSjr4 LOSjr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see "tech-work-experience.md" was created inside _projects. Content appears correct without typos. Leadership and links appear to be correct. Two new png images are placed in /assets/images/projects. Docker shows the new Tech Work Experience project card on the main page and it links to the main Tech Work Experience page. Both card and page look consistent with our other project pages. Inspecting the card and page in smaller formats also appear consistent.

This looked like a fun issue. Thank you for the good work @adrianang .

Abrosss
Abrosss approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Abrosss Abrosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request is made from the right branch, the tech-work-experience.md file was created in the _projects folder, and all the assets added to correct folders. I ran the code in my local environment, and I can see that the added project is displayed correctly, and all the links are working. The screenshots of the changes are also attached to the pull request. Nice job @adrianang, thank you for paying attention to all the details!

chrismenke45
chrismenke45 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@chrismenke45 chrismenke45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianang Great Work! The page looks good, all the links seem to be working properly and all of the files have been added to the appropriate folders

@chrismenke45 chrismenke45 merged commit 2e354f7 into hackforla:gh-pages Jul 5, 2023
@chrismenke45 chrismenke45 mentioned this pull request Jul 5, 2023
Closed
21 tasks
@adrianang adrianang mentioned this pull request Jul 7, 2023
Closed
34 tasks
ronaldpaek pushed a commit to ronaldpaek/website that referenced this pull request Jul 13, 2023
@adrianang @ronaldpaek
Add Tech Work Experience project and its associated files to website (h…
238071a 
…ackforla#4911)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LOSjr4 LOSjr4 LOSjr4 approved these changes

@chrismenke45 chrismenke45 chrismenke45 approved these changes

@Abrosss Abrosss Abrosss approved these changes

Assignees
No one assigned
Labels
Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new project to website: Tech Work Experience
4 participants
@adrianang @Abrosss @chrismenke45 @LOSjr4