added Leo Peng to file for issue#6104

[kevin-421]

Fixes #6104

What changes did you make?

• Added team member leo peng to the "_data/internal/communities/ui-ux.yml" file.

Why did you make the changes (we will use this info to test)?

• To keep project information up to date so that visitors can be informed on all recent changes.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b kevin-421-update-communities-of-practice-ui-ux-add-leo-peng-6104 gh-pages
git pull https://github.com/kevin-421/hackforla-website.git update-communities-of-practice-ui-ux-add-leo-peng-6104

---

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/kevin-421/website/blob/update-communities-of-practice-ui-ux-add-leo-peng-6104/CONTRIBUTING.md  

[njackman-2344]

Availability: Tuesday 1/23 7pm-10pm, Wednesday 5pm-10pm 1/24, Friday 5pm-10pm 1/25

ETA: Friday 1/25 EOD

[KyleA99]

ETA: 1/23/24 EOD
Availability: 1/23/24 all day

[KyleA99]

@kevin-421

• Your PR is done with the correct branch.
• Your code needs to be modified slightly - see inline comment.
• These changes do actually affect the website visuals, please add a screenshot to your pull request once the code has been modified.

Feel free to reach out to me if you need any assistance.

Great work

[LRenDO]

Hi @kevin-421!

Great job with the "what" and the "why" as well as the branching! In addition to any changes requested by your reviewers, please also remove the unused bullet points in the original pull request comment. Though it's non-functional, we like to keep them clean. I would also change team member in the PR title to Leo Peng for clarity as we often have issues very similar to this one.

@KyleA99 mentioned that the visuals do change. These changes will occur on the Communities of Practice page. The affected pages are often included in the resource section of the issue.

If you have any questions, feel free to reach out. Thanks for taking the time to contribute and make updates!

[KyleA99]

PR approved. Great work @kevin-421

• Code is properly changed and looks great visually.

Thank you for your contributions!

[njackman-2344]

Great work @kevin-421

Like @KyleA99 said, Code and visuals look good.

[jphamtv]

Hey @kevin-421, thanks for making the changes requested by @KyleA99 and @LRenDO.

I noticed the action items on the issue aren't checked off. Please make sure to mark them as completed. It helps track progress and keeps the team updated on what's done and what still needs attention.

Also, an edit was made that's out of scope. It's minor, but to maintain consistency with other yml files, revert the removal of the blank line above recruiting-messages:. Thanks!

[kevin-421]

Hello @jphamtv I see that you want me to check off actions items, but I cannot see where they are located can you point me in the right direction. And I also went ahead and deleted the blank line and pushed the code up thank you.

[jphamtv]

Hey @kevin-421 , I'm sorry if my previous feedback wasn't clear. Let me try explaining again:

• The Action Items to be checked off are located in the issue here: Update Communities of Practice: UI/UX (Add Leo Peng) #6104.

• What I originally meant to say is to restore the blank line that used to be between the links: and recruiting-message: sections. Keeping the blank line there would make the formatting consistent with the other .yml files within the communities folder. Here's what lines 46–53 should look like:

links:
  - name: Slack
    url: https://app.slack.com/client/T04502KQX/C017ESHSMNG/
  - name: Github
    url: https://github.com/hackforla/UI-UX
    
recruiting-message:
---

Let me know if this makes sense. I'm happy to clarify further if needed. Please re-request reviews once you've made the changes. To re-request reviews, click the icon with the arrows next to the reviewer names. Thanks!

[kevin-421]

yes it makes sense @jphamtv thank you for clarifying. I went ahead and make the changes let me know If anything else needs correcting. Thank you!

[njackman-2344]

I see the consistent code markup as suggested from @jphamtv . I apologize I didn't account for that earlier.

The visuals support the change before and after. The branch commit matches.

Great Job @kevin-421

[jphamtv]

yes it makes sense @jphamtv thank you for clarifying. I went ahead and make the changes let me know If anything else needs correcting. Thank you!

Hey @kevin-421, you're almost there. Just remove the indentation on line 46 and you should be all set.

[kevin-421]

Hello @jphamtv correct me if I am wrong but I went ahead and looked at the rest of the code on the file. It looks like all of the indentation is the same for the "links:".

[KyleA99]

@kevin-421 I just looked over the current code for this PR and I believe that there is an indentation/nesting issue with "links:" on line 46. Please note that it appears we are using an internal "links:" for each leadership profile, and also a separate "links:" under/after the leadership profiles.

If you refer back to the original code (https://github.com/hackforla/website/blob/gh-pages/_data/internal/communities/ui-ux.yml), the "links:" is not indented/nested inside of the last leadership profile. I believe this issue is also throwing off the visuals, currently.

I'll be available all day if you have any questions. Feel free to message me on slack, or tag me in a comment here and we can converse.

[Thinking-Panda]

Availability: Weekdays
Review ETA: 1/30/24

[kevin-421]

hello @KyleA99 I went ahead and removed the indentation, the visuals are now looking good.

[KyleA99]

Code and visuals appear properly changed now. Approved! Great job @kevin-421

[Thinking-Panda]

@kevin-421 , Thank you for working on this issue. Merge branches are correct. Code changes give desired results. Website works well in local machine. Well done. Approved!

[jphamtv]

@KyleA99, thanks for providing detailed feedback on the indentation issue.

@kevin-421, appreciate your efforts on this pull request. All looks good now.

[njackman-2344]

branches are mergeable.

Code format is specified to standards.

Thank you!