Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved CodeQL alert 9 "Potentially unsafe external link" #6190

Merged

Conversation

nelsonuprety1
Copy link
Member

@nelsonuprety1 nelsonuprety1 commented Jan 29, 2024

Fixes #6043

What changes did you make?

  • Added the attribute rel="noopener noreferrer" to the given p tag.

Why did you make the changes (we will use this info to test)?

  • The change was made to resolve the alert Potentially unsafe external link.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

No visual changes to the website.

Visuals after changes are applied

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nelsonuprety1-resolve-codeql-alert-6043 gh-pages
git pull https://github.com/nelsonuprety1/website.git resolve-codeql-alert-6043

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/nelsonuprety1/website/blob/resolve-codeql-alert-6043/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Code Alerts labels Jan 29, 2024
@pdimaano pdimaano self-requested a review January 29, 2024 18:41
@pdimaano
Copy link
Member

ETA: 2/1/2024
Availability: Weekday evenings

@Chrisklangley Chrisklangley self-requested a review January 29, 2024 22:26
@Chrisklangley
Copy link
Contributor

ETA: 1/31/2024 EOD
Availability: M-F 6:30pm-9pm

Copy link
Contributor

@Chrisklangley Chrisklangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nelsonuprety1

NIce work on your Pull Request.

You correctly linked your issue in your PR. You gave clear documentation on the changes you made and why you made them. On line 195 I see that you correctly added the rel="noopener noreferrer" attribute to the paragraph tag stated in your issue.

Great work! The only critique I have for you is since you don't have an visible changes on the web page there is no need for you to include screenshots of your changes.

@Thinking-Panda
Copy link
Member

Availability: Weekdays
Review ETA: 1/30/24

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonuprety1 , Thank you for working on this issue. Merge branches look good, code changes are as mentioned in the issue and clean. Website works perfect on my local machine. Well done!

Copy link
Member

@pdimaano pdimaano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nelsonuprety1 Good job: The branches are correct and the issue is linked. There are no visual changes on my system on desktop, tablet or mobile. The correct file was changed and the appropriate line of code was updated. Well done!

As stated previously by @Chrisklangley, pull requests do not require before and after screenshots if no visible changes are present. You can simply write something like "No visual changes to the website" in that section. Please keep this in mind regarding future pull requests.

@roslynwythe roslynwythe merged commit 0729337 into hackforla:gh-pages Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 9 "Potentially unsafe external link"
5 participants