-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved CodeQL alert 9 "Potentially unsafe external link" #6190
Resolved CodeQL alert 9 "Potentially unsafe external link" #6190
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: 2/1/2024 |
ETA: 1/31/2024 EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nelsonuprety1
NIce work on your Pull Request.
You correctly linked your issue in your PR. You gave clear documentation on the changes you made and why you made them. On line 195 I see that you correctly added the rel="noopener noreferrer" attribute to the paragraph tag stated in your issue.
Great work! The only critique I have for you is since you don't have an visible changes on the web page there is no need for you to include screenshots of your changes.
Availability: Weekdays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonuprety1 , Thank you for working on this issue. Merge branches look good, code changes are as mentioned in the issue and clean. Website works perfect on my local machine. Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonuprety1 Good job: The branches are correct and the issue is linked. There are no visual changes on my system on desktop, tablet or mobile. The correct file was changed and the appropriate line of code was updated. Well done!
As stated previously by @Chrisklangley, pull requests do not require before and after screenshots if no visible changes are present. You can simply write something like "No visual changes to the website" in that section. Please keep this in mind regarding future pull requests.
Fixes #6043
What changes did you make?
rel="noopener noreferrer"
to the givenp
tag.Why did you make the changes (we will use this info to test)?
Potentially unsafe external link
.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
No visual changes to the website.
Visuals after changes are applied
No visual changes to the website.