Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wins app script to add spacing and line breaks to wins json feed #6205

Conversation

Jung-GunSong
Copy link
Member

@Jung-GunSong Jung-GunSong commented Feb 1, 2024

…etween items and line breaks inbetwen arrays

Fixes #4035

What changes did you make?

  • Added a spacer parameter to JSON.stringify() on line 68

Why did you make the changes (we will use this info to test)?

  • Adds line breaks in between arrays and indentation for array elements in the _wins-data.json.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

There were no visual changes to the website

JSON before changes are applied

image

JSON after changes are applied

![image](
https://github.com/hackforla/website/assets/121644228/b4223dba-f50f-4236-9eaf-c25f3186a837

)

Link to "Update wins-data.json via Google Apps Script" PR: Jung-GunSong#5

…etween items and line breaks inbetwen arrays
Copy link

github-actions bot commented Feb 1, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Jung-GunSong-update-wins-google-ad-script-to-format-wins-4035 gh-pages
git pull https://github.com/Jung-GunSong/website.git update-wins-google-ad-script-to-format-wins-4035

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Jung-GunSong/website/blob/update-wins-google-ad-script-to-format-wins-4035/CONTRIBUTING.md  

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Feb 1, 2024
@roslynwythe roslynwythe self-requested a review February 1, 2024 20:49
@freaky4wrld freaky4wrld self-requested a review February 5, 2024 06:05
@freaky4wrld
Copy link
Member

ETA: EoD 2/6/24
Availability: Evenings

@freaky4wrld
Copy link
Member

@Jung-GunSong please refer the action items and make changes in the PR.....

In the pull request, provide links to the "Update wins-data.json via Google Apps Script" Pull Request and also the Wins page (both in your repository), for the convenience of reviewers.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far @Jung-GunSong. You created a well-formed PR that describes your work. The code in main() actually creates two json feeds: wins-data.json (starting at line 91) and _wins-data.json (starting at line 68). You have the correct strategy for formatting the json, but it should be applied to section of code that generates _wins-data.json.

@Jung-GunSong
Copy link
Member Author

Jung-GunSong commented Feb 6, 2024

@roslynwythe I understand and apologize for the confusion. I've updated the JSON.stringify() to include the spacer for the _wins-data.json. I hope this fixes the issue.

@freaky4wrld I was able to add the link for the PR, but I'm not sure what the "wins page" is, so I'd like some clarification on if the right link was provided for it.

@roslynwythe
Copy link
Member

roslynwythe commented Feb 7, 2024

@Jung-GunSong @freaky4wrld I realized that my instruction to post a link to the wins page (in your repository) was not complete, because to enable reviewers to view the /wins page, it would require configuration of GitHub pages on your repository, I will do some testing and refine the instructions while I review the latest commit.

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jung-GunSong @freaky4wrld I confirmed that this branch is working by merging the formatted feed into my repository.

@roslynwythe roslynwythe merged commit efdecd1 into hackforla:gh-pages Feb 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wins Google Apps Script to format wins json feed
3 participants