-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated wins app script to add spacing and line breaks to wins json feed #6205
Updated wins app script to add spacing and line breaks to wins json feed #6205
Conversation
…etween items and line breaks inbetwen arrays
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: EoD 2/6/24 |
@Jung-GunSong please refer the action items and make changes in the PR.....
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far @Jung-GunSong. You created a well-formed PR that describes your work. The code in main()
actually creates two json feeds: wins-data.json (starting at line 91) and _wins-data.json (starting at line 68). You have the correct strategy for formatting the json, but it should be applied to section of code that generates _wins-data.json.
@roslynwythe I understand and apologize for the confusion. I've updated the JSON.stringify() to include the spacer for the _wins-data.json. I hope this fixes the issue. @freaky4wrld I was able to add the link for the PR, but I'm not sure what the "wins page" is, so I'd like some clarification on if the right link was provided for it. |
@Jung-GunSong @freaky4wrld I realized that my instruction to post a link to the wins page (in your repository) was not complete, because to enable reviewers to view the /wins page, it would require configuration of GitHub pages on your repository, I will do some testing and refine the instructions while I review the latest commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jung-GunSong @freaky4wrld I confirmed that this branch is working by merging the formatted feed into my repository.
…etween items and line breaks inbetwen arrays
Fixes #4035
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
There were no visual changes to the website
JSON before changes are applied
JSON after changes are applied
![image](
https://github.com/hackforla/website/assets/121644228/b4223dba-f50f-4236-9eaf-c25f3186a837
)
Link to "Update wins-data.json via Google Apps Script" PR: Jung-GunSong#5