Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CodeQL alert 15 "Potentially unsafe external link" #6261

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/add-github-handle.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
name: github-handle in project file
about: For adding github-handle to member data in a project file
title: Add github-handle for [INSERT NAME] in [INSERT PROJECT FILE]
labels: 'good first issue, P-Feature: Project Info and Page, ready for dev lead, role:
back end/devOps, role: front end, size: 0.25pt'
about: 'For adding github-handle to member data in a project file'
title: 'Add github-handle for [INSERT NAME] in [INSERT PROJECT FILE]'
labels: 'P-Feature: Project Info and Page, good first issue, ready for dev lead, role: back
end/devOps, role: front end, size: 0.25pt'
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/alt-text-audit--dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: Alt Text Audit - Dev
about: Developer template to update an alt text
title: "[INSERT PAGE HERE]: Update alt text for [INSERT IMAGE NAME HERE] image to
adhere to WCAG"
labels: 'Complexity: Missing, Feature: Accessibility, good first issue, ready for
dev lead, role: back end/devOps, role: front end, size: 1pt'
labels: ['Feature: Accessibility', 'good first issue', 'ready for dev lead', 'role: back end/devOps', 'role: front end', 'size: 1pt', 'Complexity: Missing']
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/creating-a-yml-file-for-a-sdg.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Creating a yml file for a SDG
about: Creating a yml file for a SDG (Sustainable Development Goal)
title: Creating a yml file for SDG [INSERT SDG NUMBER HERE]
labels: 'Complexity: Small, p-feature: SDGs, role: front end, size: 0.25pt'
labels: ['Complexity: Small','p-feature: SDGs','role: front end','size: 0.25pt']
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/design-system-audit--text-elements.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ name: 'Design System Audit: Text Elements'
about: 'setups up and instructs how to do an audit of the text elements of a page
in Figma '
title: 'Design System Audit: Text Elements: [replace with page name] page'
labels: 'Complexity: Missing, Feature Missing, good first issue, role: design, size:
0.25pt'
labels: ['Feature Missing', 'good first issue', 'role: design', 'size: 0.25pt', 'Complexity: Missing']
assignees: ''

---
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/emergent-request.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Emergent Request
about: When you discover something in your issue that is out of scope and it needs
a new issue or discussion
title: 'ER: [replace with info ] '
labels: 'Complexity: Missing, ER, Feature Missing, role missing, size: 0.25pt'
labels: 'Complexity: Missing, Feature Missing, role missing, size: 0.25pt'
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/pre-work-template---design.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Pre-work Template - Design
about: New Design team members should start with by making this issue for themselves.
title: 'Pre-work Checklist: Designer: [replace brackets with your name]'
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role: design, size:
1pt'
labels: ['Complexity: Prework, Feature: Onboarding/Contributing.md, prework, role: design, size: 1pt']
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/pre-work-template---ux.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Pre-work Template - UX
about: New Research team members should start by making this issue
title: 'Pre-work Checklist: Researcher: [replace brackets with your name]'
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role: user research,
size: 1pt'
labels: ['Complexity: Prework, Feature: Onboarding/Contributing.md, prework, role: user research, size: 1pt']
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/pre-work-template--dev.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Pre-work Template - Developers
about: New developer team members should start by making this issue for themselves
title: 'Pre-work Checklist: Developer: [replace brackets with your name]'
labels: 'Complexity: Prework, Feature: Onboarding/Contributing.md, role missing, size:
1pt'
labels: ['Feature: Onboarding/Contributing.md', 'prework', 'size: 1pt', 'role missing', 'Complexity: Prework']
assignees: ''

---
Expand Down
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/spell-check-audit.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
name: Spell check audit web page
about: For checking spelling on a code file that contains text displayed on the website
title: Run VS Code Spell Checker on [INSERT FILE HERE]
labels: 'Complexity: Small, Feature: Administrative, ready for dev lead, role: back
about: 'For checking spelling on a code file that contains text displayed on the website'
title: 'Run VS Code Spell Checker on [INSERT FILE HERE]'
labels: 'Feature: Administrative, Complexity: Small, ready for dev lead, role: back
end/devOps, role: front end, size: 0.5pt'
assignees: ''

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: Suggest a feature or new content for HackforLA.org
about: Describe this issue template's purpose here.
title: ''
labels: 'Complexity: Missing, enhancement, Feature Missing, role missing, size: missing'
labels: ['enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']
assignees: ''

---
Expand Down
3 changes: 1 addition & 2 deletions .github/ISSUE_TEMPLATE/suggest-a-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Suggest a guide
about: 'For guides that could be helpful and listed on the toolkit page. '
title: ''
labels: 'Complexity: Missing, documentation, enhancement, Feature Missing, role missing,
size: missing'
labels: ['documentation', 'enhancement', 'role missing', 'Feature Missing', 'Complexity: Missing', 'size: missing']
assignees: ''

---
Expand Down
5 changes: 2 additions & 3 deletions .github/ISSUE_TEMPLATE/update-CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
---
name: Update CONTRIBUTING.md
about: For making updates to CONTRIBUTING.md
about: 'For making updates to CONTRIBUTING.md'
title: 'Update CONTRIBUTING.md Section [INSERT SECTION #]'
labels: 'Complexity: Small, Feature: Wiki, role: back end/devOps, role: front end,
size: 0.5pt'
labels: 'Feature: Wiki, Complexity: Small, role: back end/devOps, role: front end, size: 0.5pt'
assignees: ''

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: 'Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE]'
about: Research Plan Review
title: 'Wiki: Research Plan Review: [REPLACE WITH NAME OF PAGE]'
labels: 'Complexity: Missing, Feature: Wiki, role: user research, size: 0.5pt'
labels: ['Feature: Wiki', 'role: user research', 'size: 0.5pt', 'Complexity: Missing']
assignees: sacamp

---
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/issue-trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
- name: Add issue to project board
id: add-issue-project-board
uses: alex-page/github-project-automation-plus@v0.9.0
uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: ${{ env.COLUMN_NAME }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/move-closed-issues.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
const sortIssues = script({context})
return sortIssues
result-encoding: string
- uses: alex-page/github-project-automation-plus@v0.9.0
- uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: ${{ steps.sort-closed-issues.outputs.result }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pull-request-trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
if: ${{ github.event.action == 'opened' }}
steps:
- name: Move Opened PR to Project Board
uses: alex-page/github-project-automation-plus@v0.9.0
uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: 'PR Needs review (Automated Column, do not place items here manually)'
Expand All @@ -32,7 +32,7 @@ jobs:
if: ${{ github.event.pull_request.merged == true }}
steps:
- name: Gather Merged PRs
uses: alex-page/github-project-automation-plus@v0.9.0
uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: 'test-approved-by-reviewer (Automated Column, do not place items here manually)'
Expand All @@ -46,7 +46,7 @@ jobs:
if: ${{ github.event.pull_request.merged == true }}
steps:
- name: Delete Merged PRs
uses: alex-page/github-project-automation-plus@v0.9.0
uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: 'test-approved-by-reviewer (Automated Column, do not place items here manually)'
Expand All @@ -59,7 +59,7 @@ jobs:
if: ${{ github.event.pull_request.merged == false && github.event.action == 'closed' }}
steps:
- name: Delete Closed and Unmerged PRs
uses: alex-page/github-project-automation-plus@v0.9.0
uses: alex-page/github-project-automation-plus@v0.8.3
with:
project: Project Board
column: 'PR Needs review (Automated Column, do not place items here manually)'
Expand Down
18 changes: 15 additions & 3 deletions .github/workflows/schedule-monthly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,19 @@ jobs:
with:
github-token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }}
script: |
const artifactContent = process.env.TRIM_LISTS
const script = require('./github-actions/trigger-schedule/list-inactive-members/create-new-issue.js')
script({g: github, c: context}, artifactContent)
const artifactContent = process.env.TRIM_LISTS;
const script = require('./github-actions/trigger-schedule/list-inactive-members/create-new-issue.js');
const createNewIssue = script({g: github, c: context}, artifactContent);
return createNewIssue;

# Comments on issue #2607, notifying leads that the above issue has been created
- name: Comment issue
uses: actions/github-script@v7
id: comment-issue
with:
github-token: ${{ secrets.HACKFORLA_BOT_PA_TOKEN }}
script: |
const script = require('./github-actions/trigger-schedule/list-inactive-members/comment-issue.js');
const newIssueNumber = ${{ steps.create-new-issue.outputs.result }};
script({g: github, c: context}, newIssueNumber);

14 changes: 10 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -530,12 +530,18 @@ If you are not currently in the `gh-pages` branch, run the following command to
git checkout gh-pages
```

Update your gh-pages branch with upstream changes
**IMPORTANT:** Before you push your local commits to your repository, sync your fork to the main Hack For LA website repository. `git pull upstream` will ensure that your local repository is up-to-date with the main site:

```bash
git pull upstream
```
git pull upstream gh-pages
```

You can also sync your fork directly on GitHub by clicking "Sync Fork" at the right of the screen and then clicking "Update Branch"

<details>
<summary><strong>Click here</strong> to see how to sync the fork on GitHub</summary>
<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png" />
</details>

<sub>[Back to Table of Contents](#table-of-contents)</sub>

Expand Down Expand Up @@ -793,7 +799,7 @@ ssh-keygen -t rsa -b 4096 -C "your_email@example.com"
eval "$(ssh-agent -s)"
```

4. Next you need to add your ssh key to your ssh agent. In the command below, replace `id_ed25519` with the filename (without file extension) you provided in the previous step.
4. Next you need to add your ssh key to your ssh agent

```bash
ssh-add ~/.ssh/id_ed25519
Expand Down
2 changes: 1 addition & 1 deletion _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ url: https://www.hackforla.org
# 2. Collection — Will have its own page, URLs, and possibly an index page. [https://gist.github.com/akibrhast/31c7bb723d80e9efe3d28f619ef0798d]
collections:
# The redirection collection exist to allow us to type urls `hackforla.org/github` or hackforla.org/donate
# which then redirects to `github.com/hackforla/website` and `https://www.hackforla/donate` respectively
# which then redirects to `github.com/hackforla/website` and `https://www.codeforamerica.org/donate` respecitively
redirections:
output: true
projects:
Expand Down
Loading