added rel attribute to anchor tag #6282
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
good first issue
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -47,7 +47,7 @@ | |||
| <div class='leader-list--communities'> | |||
| {% for leader in community[1].leadership %} | |||
| <div class='leader-card--communities'> | |||
| <a href='{{ leader.links.github }}' target='_blank' title='GitHub Profile'><img class='leader-img--communities' src='{{ leader.picture }}'/></a> | |||
| <a href='{{ leader.links.github }}' target='_blank' title='GitHub Profile'><img class='leader-img--communities' src='{{ leader.picture }}' rel='noopener noreferrer'/></a> | |||
Check warning
Code scanning / CodeQL
Potentially unsafe external link Medium
|
Created new pull request to address will's comment regarding my branch. |
There was a problem hiding this comment.
Hey @aidanwsimmons Thanks for making the requested edits and resubmitting the PR. Everything looks perfect: the branches from and to are correct, the link back to the original issue is provided, there are concise descriptions of what was done and why, and there are is a note stating 'No visual changes to the website'.
@gaylem and @njackman-2344 thank you for your previous reviews and comments. Since you already reviewed the previous PR, I will go ahead and merge this one.
Great job again and thanks for contributing!
Fixes #6054
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.