Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update project profile food oasis reorder leadership member #6387

Conversation

angela-lee1
Copy link
Member

@angela-lee1 angela-lee1 commented Feb 28, 2024

Fixes #6313

What changes did you make?

  • In _projects/food-oasis.md
  • moved Hannah Zulueta's profile information to be under John Darragh's profile information
  • verified changes on local system

Why did you make the changes (we will use this info to test)?

  • We need to reorder the way the leadership team members are displayed on the Food Oasis page
  • Members with the same role need to be grouped

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b awlFCCamp-update-project-profile-food-oasis-6313 gh-pages
git pull https://github.com/awlFCCamp/website.git update-project-profile-food-oasis-6313

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/awlFCCamp/website/blob/update-project-profile-food-oasis-6313/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 28, 2024
@luisitocanlas luisitocanlas self-requested a review February 28, 2024 18:24
@luisitocanlas
Copy link
Member

Review ETA: EOD 2/28/24
Availability: 2/28/24

Copy link
Member

@luisitocanlas luisitocanlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @awlFCCamp ,

  • Pull request is done with the correct branch.

  • The issue is linked properly.

  • Pull request changes, reasoning, and screenshots were provided.

  • Changes are reflected on the browser.

  • Everything else looks good.

Thank you!

@Thinking-Panda Thinking-Panda self-requested a review February 28, 2024 18:51
@Thinking-Panda
Copy link
Member

Availability: Weekdays
Review ETA:2/28/24

Copy link
Member

@Thinking-Panda Thinking-Panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awlFCCamp Thank you for working on this issue. Merge branches are set up correctly. PR description is clear with visuals. Code changes are clean and as mentioned in the issue. Well done!

@Thinking-Panda Thinking-Panda merged commit de5c148 into hackforla:gh-pages Feb 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Food Oasis (Reorder leadership member)
3 participants