Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve CodeQL alert #6400

Merged
merged 1 commit into from
Mar 1, 2024
Merged

fix: resolve CodeQL alert #6400

merged 1 commit into from
Mar 1, 2024

Conversation

anthonypz
Copy link
Member

Fixes #6049

What changes did you make?

  • Added the rel="noopener noreferrer attribute to external links

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

No visual changes.

Visuals after changes are applied

No visual changes.

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b anthonypz-fix-unsafe-external-link-6049 gh-pages
git pull https://github.com/anthonypz/website.git fix-unsafe-external-link-6049

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/anthonypz/website/blob/fix-unsafe-external-link-6049/CONTRIBUTING.md

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Code Alerts labels Feb 29, 2024
@KuanHsienYEH
Copy link
Member

Review ETA: 13 PM 29/2/24
Availability: 11-13 PM Thu

KuanHsienYEH
KuanHsienYEH approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@KuanHsienYEH KuanHsienYEH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I love what you have done, Thanks @anthonypz !

@jtw007 jtw007 self-requested a review February 29, 2024 20:23
@jtw007
Copy link
Member

jtw007 commented Feb 29, 2024

Review ETA Feb 29 2024
Availability: this afternoon

jtw007
jtw007 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@jtw007 jtw007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Branches are correct and issue is linked.
Correct file and information has been changed.

@jphamtv jphamtv merged commit 9409cc7 into hackforla:gh-pages Mar 1, 2024
10 checks passed
@anthonypz anthonypz deleted the fix-unsafe-external-link-6049 branch March 1, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuanHsienYEH KuanHsienYEH KuanHsienYEH approved these changes

@jtw007 jtw007 jtw007 approved these changes

Assignees
No one assigned
Labels
Feature: Code Alerts good first issue Good for newcomers P-Feature: Communities of Practice https://www.hackforla.org/communities-of-practice ready for dev lead Issues that tech leads or merge team members need to follow up on role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve CodeQL alert 15 "Potentially unsafe external link"
4 participants
@anthonypz @KuanHsienYEH @jtw007 @jphamtv