Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a potentially dangerous link #6508

Merged

Conversation

DakuwoN
Copy link
Member

@DakuwoN DakuwoN commented Mar 23, 2024

Fixes #6484

What changes did you make?

  • Added noopener and noreferrer rel attribute to the anchor tag

Why did you make the changes (we will use this info to test)?

  • For security purposes

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visible changes to the website.

@DakuwoN DakuwoN requested a review from kwangric March 23, 2024 05:24
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b DakuwoN-unsafe-external-link-6484 gh-pages
git pull https://github.com/DakuwoN/website.git unsafe-external-link-6484

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/DakuwoN/website/blob/unsafe-external-link-6484/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Code Alerts labels Mar 23, 2024
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
I have inspected and confirmed the changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.

Going forward, please delete the image example and indicate that there are no visible changes to the website.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DakuwoN - Thanks for working on this issue. Your summary of changes is clear and your code change is clean and accurate.

Great work!

@jphamtv jphamtv removed the Complexity: Small Take this type of issues after the successful merge of your second good first issue label Mar 29, 2024
Copy link
Member

@evan-ishibashi evan-ishibashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and has been changed as requested. Nice!

@drakenguyen4000 drakenguyen4000 merged commit 6ad0dae into hackforla:gh-pages Mar 31, 2024
11 checks passed
freaky4wrld pushed a commit to freaky4wrld/website that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Code Alerts good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve "Potentially unsafe external link" in _includes/current-guides.html
5 participants