-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. #7065
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DakuwoN thanks for working on this issue. The only feedback I have is making the title of the PR more descriptive to summarize what the goal of the issue is. Other than that nice job!
Here's what you did well.
- Into and from branch are correct
- The issue linked is correct
- Appropriate files were changed, no indentation was applied, and github-handle variable was added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DakuwoN! Overall looks great!
- The branching was done correctly
- Issue number was listed
- Changes were made correctly in the code
- Changes do not impact the site
- A note was included that there were no visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
I have one non-functional request. Please change the title to something descriptive of the changes. For example, "Added github handle to _projects/heart.md
for Jason LaManque". You can click the circle with the arrows next to my handle in the reviewers section to re-request a review once it's updated. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated title looks great! Thanks for contributing and making the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct format
Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.