Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. #7065

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

DakuwoN
Copy link
Member

@DakuwoN DakuwoN commented Jun 26, 2024

Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

What changes did you make?

  • Add Github handle to markdown file

Why did you make the changes (we will use this info to test)?

  • Reduce redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b DakuwoN-add-github-handle-7046 gh-pages
git pull https://github.com/DakuwoN/website.git add-github-handle-7046

@DakuwoN DakuwoN requested a review from mSharifHub June 26, 2024 03:05
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 26, 2024
@Anahisv23 Anahisv23 self-requested a review June 26, 2024 20:33
@Anahisv23
Copy link
Member

ETA: EOD
Availability: M - F 11am - 5pm

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DakuwoN thanks for working on this issue. The only feedback I have is making the title of the PR more descriptive to summarize what the goal of the issue is. Other than that nice job!

Here's what you did well.

  • Into and from branch are correct
  • The issue linked is correct
  • Appropriate files were changed, no indentation was applied, and github-handle variable was added

@LRenDO LRenDO self-requested a review June 26, 2024 23:13
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DakuwoN! Overall looks great!

  • The branching was done correctly
  • Issue number was listed
  • Changes were made correctly in the code
  • Changes do not impact the site
  • A note was included that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

I have one non-functional request. Please change the title to something descriptive of the changes. For example, "Added github handle to _projects/heart.md for Jason LaManque". You can click the circle with the arrows next to my handle in the reviewers section to re-request a review once it's updated. Thanks!

@DakuwoN DakuwoN changed the title Fixes #7046 Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque. Jun 27, 2024
@DakuwoN DakuwoN requested a review from LRenDO June 27, 2024 02:06
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated title looks great! Thanks for contributing and making the change!

@LRenDO LRenDO merged commit 58e87cc into hackforla:gh-pages Jun 27, 2024
8 of 9 checks passed
Copy link
Member

@mSharifHub mSharifHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Jason LaManque in heart.md
4 participants