-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment to PR if there's no linked issue #7228
Add comment to PR if there's no linked issue #7228
Conversation
reset branch
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
removing unused module
remove variable and run REST API directly, add reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @t-will-gillis, I tested this in my repo and the workflow seems to be working correctly:
- When no issue is linked in a PR, the appropriate comment is posted
- When an invalid issue number is linked, the appropriate comment is posted
- Otherwise if a valid issue is linked, no comment is posted
- Action is triggered when opening new PR or editing existing PR
Additionally you edited/added the files as called for in the original issue and your PR is set up correctly. Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @t-will-gillis excellent work on this PR.
I tested the workflow on my repo and it works as intended without any issues.
When no issue number or an invalid issue number is provided, relevant comments appear. And when a valid issue number is provided, no comments.
* Update pull-request-trigger.yml * Create check-linked-issue.js * Update pull-request-trigger.yml * Update pull-request-trigger.yml * Update check-linked-issue.js * Update check-linked-issue.js * Update pull-request-trigger.yml reset branch * Update check-linked-issue.js * Update check-linked-issue.js removing unused module * Update check-linked-issue.js remove variable and run REST API directly, add reference
Fixes #7140
What changes did you make?
pull-request-trigger.yml
, replaced existing with code reference to jsgithub-actions/trigger-pr/
folder createdcheck-linked-issue.js
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Testing logs and test PRs
Notes for testing
This test involves GitHub actions. To review, you will need to have a testing environment set up in your repo. Suggestions:
pull-request-trigger.yml
, change line 6 to: