-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused component _includes/calendar.html
#7361
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @codyyjxn, Nicely done!
- The branches from and to are setup correctly
- Link to the issue is included
- There is a detailed description of what was done and why
No screenshots
is mentioned
Thanks for working on this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @codyyjxn, great job working on this issue!
- Branches are set up correctly
- Original issue is linked in your PR
- Clear explanation of changes and why they were necessary
- File deleted does not affect the website
Just a reminder, when you assign yourself to an issue don't forget to move it from "Prioritized Backlog" to "In Progress" on the Project Board.
Thanks totally forgot to do that. Can I now move it to "test-approved-by-reviewer" ? @daras-cu |
@codyyjxn I think you can just move it to In Progress, the "test-approved-by-reviewer" is an automated category for PRs. |
Fixes #7282
What changes did you make?
_includes/calendar.html
pages/index.html
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)