Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Ahmed Awadalla project profile from 311 Data #7559

Merged

Conversation

Sujay-Anantha
Copy link
Member

@Sujay-Anantha Sujay-Anantha commented Oct 3, 2024

Fixes #7549

What changes did you make?

  • Removed the project profile of Ahmed Awadalla in 311data.md

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Before
Visuals after changes are applied After

Copy link

github-actions bot commented Oct 3, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b Sujay-Anantha-update-profile-remove-ahmed-7549 gh-pages
git pull https://github.com/Sujay-Anantha/website.git update-profile-remove-ahmed-7549

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 3, 2024
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sujay-Anantha Thank you for your contribution!

  • The branch name is correct
  • You provided screenshots that is a plus
  • The issue is linked correctly
  • The tittle is clear and concise.

Great Job !

@t-will-gillis
Copy link
Member

t-will-gillis commented Oct 6, 2024

Hi @Sujay-Anantha Please do not request reviewers for PRs unless you have communicated with the person first, or if the person previously reviewed the same PR and you need them to re-review. One of your requested reviewers is no longer active on the team, and sometimes the person requested does not have time available to review. When other reviewers look for PRs to review, they will skip yours because they will mistakenly believe your PR is well-covered

@t-will-gillis t-will-gillis removed their request for review October 6, 2024 18:22
@santisecco santisecco self-requested a review October 7, 2024 13:29
Copy link
Member

@santisecco santisecco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sujay-Anantha everything is correct. Branches, description of your work and code update of 311-data.md file. I also run the website locally and visualized the changes as expected.
Thanks for working on this.

@daras-cu daras-cu merged commit 78e23ab into hackforla:gh-pages Oct 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: 311 Data Remove Ahmed Awadalla
5 participants