Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: VRMS Add Jack Haeger #7592

Merged

Conversation

theogguu
Copy link
Member

Fixes #7473

What changes did you make?

  • Added Jack Haeger to leadership variable in the VRMS .md file
  github-handle: JackHaeg
  role: Lead Product Manager
  links:
    slack: https://hackforla.slack.com/team/U059005TN1L
    github: https://github.com/JackHaeg
  picture: https://avatars.githubusercontent.com/JackHaeg

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied 7473-before
Visuals after changes are applied 7473-after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b theogguu-update-profile-add-haeger-7473 gh-pages
git pull https://github.com/theogguu/website.git update-profile-add-haeger-7473

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 14, 2024
@pluto-bell pluto-bell self-requested a review October 14, 2024 22:43
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

The new profile is added correctly in the code base and the new profile card populates on the VRMS project page like it should.

Provided a good explanation as to why the changes were made and visuals for before and after.

My only suggestion is to be more specific with your git branch naming in the future. In this case, it would allow us to quickly know the profile is being added to the VRMS project specifically.

@DrAcula27 DrAcula27 self-requested a review October 15, 2024 02:17
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theogguu Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/vrms.md was edited
  • No extra edits were made
  • Appearance of the website looks just like your screenshots (Chrome and Firefox)
  • I agree with the nitpick from the other reviewer: naming your issue branch so that which project was modified is in the name would be more clear.
    Approved! 👍

@NolaDodd NolaDodd self-requested a review October 15, 2024 03:36
@NolaDodd
Copy link
Member

Hey! Your pull request looks good!

  • PR is the correct branch and references the correct issue
  • The explanation is good
  • The correct file and changes were made
  • The appearance of the updated website looks correct

Other than a clearer branch name like the others mentioned, everything looks good to me!

Copy link
Member

@NolaDodd NolaDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theogguu Great job on your Good first issue.

Things that went well:

  • The correct branch name
  • The correct file _projects/vrms.md was edited
  • You provided screenshots
  • Set this up in my end I was able to see what the changes you made.

Keep it up!

@Sujay-Anantha Sujay-Anantha self-requested a review October 15, 2024 16:58
@Sujay-Anantha
Copy link
Member

Great Job @theogguu,

  • The PR uses the correct naming format.
  • The PR is linked to the original issue: Update Project Profile: VRMS Add Jack Haeger #7473.
  • The summary of the work done is concise and accurately describes the changes.
  • The visual changes on the website match the screenshots provided.

@daras-cu daras-cu merged commit dad6c98 into hackforla:gh-pages Oct 16, 2024
7 checks passed
@daras-cu
Copy link
Member

Thanks for taking on this issue @theogguu, nice work. Don't forget there are a couple more action items to check off on the original issue #7473 now that this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: VRMS Add Jack Haeger
7 participants