-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Apps Script: Migrate Wins Data - Stop generation of AF file #7615
base: gh-pages
Are you sure you want to change the base?
Google Apps Script: Migrate Wins Data - Stop generation of AF file #7615
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dcotelessa thank you for tackling this issue, with a quite complex setup. Looking at the files changed, it appears that GitHub is not able to identify which lines you have changed. This may be due to a difference in the End of Line character (the result of copying code between your local workstation and Google Drive) or perhaps prettier is modifying each line. If you can figure that out and have GitHub present a useful "Diff", that would be great. Otherwise, could you give a detailed description of which lines you modified, for the benefit of reviewers? Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dcotelessa for a great job on this issue!
- You created a test environment on a development Google Drive, and test branches in the fork of your repository
- Your code change was correct and clean
- Your PR is well formed and descriptive
- You have provided feedback regarding the documentation and will create an issue to improve the instructions
availability: daily 12-3 +/- |
Fixes #2147
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Log:
Wins Data Updated: