Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Apps Script: Migrate Wins Data - Stop generation of AF file #7615

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

dcotelessa
Copy link
Member

Fixes #2147

What changes did you make?

  • Remove generation code of AF file to create/update wins-data

Why did you make the changes (we will use this info to test)?

  • Stop sgeneration of AF file

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

- No visual changes to the website

Log:
Screenshot 2024-10-20 at 11 36 16 PM

Wins Data Updated:
Screenshot 2024-10-20 at 11 39 06 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b dcotelessa-dcotelessa-winsdata-stop-af-file-2147 gh-pages
git pull https://github.com/dcotelessa/website-hackforla.git dcotelessa-winsdata-stop-af-file-2147

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers P-Feature: Wins Page https://www.hackforla.org/wins/ Feature: Google Apps Scripts Automation related to Google Apps Scripts size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created Complexity: Extra Large labels Oct 21, 2024
@dcotelessa

This comment was marked as off-topic.

@roslynwythe roslynwythe self-requested a review October 21, 2024 19:49
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dcotelessa thank you for tackling this issue, with a quite complex setup. Looking at the files changed, it appears that GitHub is not able to identify which lines you have changed. This may be due to a difference in the End of Line character (the result of copying code between your local workstation and Google Drive) or perhaps prettier is modifying each line. If you can figure that out and have GitHub present a useful "Diff", that would be great. Otherwise, could you give a detailed description of which lines you modified, for the benefit of reviewers? Thank you

Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dcotelessa for a great job on this issue!

  • You created a test environment on a development Google Drive, and test branches in the fork of your repository
  • Your code change was correct and clean
  • Your PR is well formed and descriptive
  • You have provided feedback regarding the documentation and will create an issue to improve the instructions

@roslynwythe roslynwythe marked this pull request as ready for review October 22, 2024 19:41
@t-will-gillis t-will-gillis self-requested a review October 22, 2024 21:09
@t-will-gillis
Copy link
Member

availability: daily 12-3 +/-
eta: 10/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Extra Large Draft Issue is still in the process of being created Feature: Google Apps Scripts Automation related to Google Apps Scripts P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Status: PRs being reviewed
Development

Successfully merging this pull request may close these issues.

Google Apps Script: Migrate Wins Data - Stop generation of AF file
3 participants