Google Apps Script: Migrate Wins Data - Stop generation of AF file

[dcotelessa]

Fixes #2147

What changes did you make?

• Remove generation code of AF file to create/update wins-data

Why did you make the changes (we will use this info to test)?

• Stop sgeneration of AF file

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

- No visual changes to the website

Log:

Wins Data Updated:

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b dcotelessa-dcotelessa-winsdata-stop-af-file-2147 gh-pages
git pull https://github.com/dcotelessa/website-hackforla.git dcotelessa-winsdata-stop-af-file-2147

[roslynwythe]

Hi @dcotelessa thank you for tackling this issue, with a quite complex setup. Looking at the files changed, it appears that GitHub is not able to identify which lines you have changed. This may be due to a difference in the End of Line character (the result of copying code between your local workstation and Google Drive) or perhaps prettier is modifying each line. If you can figure that out and have GitHub present a useful "Diff", that would be great. Otherwise, could you give a detailed description of which lines you modified, for the benefit of reviewers? Thank you

[roslynwythe]

Thank you @dcotelessa for a great job on this issue!

• You created a test environment on a development Google Drive, and test branches in the fork of your repository
• Your code change was correct and clean
• Your PR is well formed and descriptive
• You have provided feedback regarding the documentation and will create an issue to improve the instructions

[t-will-gillis]

availability: daily 12-3 +/-
eta: 10/23

[t-will-gillis]

Hey @dcotelessa I know that you and Roslyn have been working diligently on this issue for many weeks- I realize this is going to take some time for me to dive in to this and go through the documentation you are preparing. I will approve this PR and defer to @roslynwythe 's knowledge of this workflow. As I mentioned previously I would like to set up something similar using CLASP with one or two existing Google Apps Scripts.

Also - Woohoo your PR is addressing not just one but two CodeQL alerts (48 and 55). Do you want to go for the CodeQL triple?

Of course you do! If you add a semi-colon to the end of line 275, you will also take care of Alert 28. That will be 3 for 1.

I will temporarily submit this as a 'Comment', assuming you don't mind the last request... Great work!

[dcotelessa]

Hey @dcotelessa I know that you and Roslyn have been working diligently on this issue for many weeks- I realize this is going to take some time for me to dive in to this and go through the documentation you are preparing. I will approve this PR and defer to @roslynwythe 's knowledge of this workflow. As I mentioned previously I would like to set up something similar using CLASP with one or two existing Google Apps Scripts.

Let's set up a ticket for doing that.

Also - Woohoo your PR is addressing not just one but two CodeQL alerts (48 and 55). Do you want to go for the CodeQL triple?

Of course you do! If you add a semi-colon to the end of line 275, you will also take care of Alert 28. That will be 3 for 1.

Updated.

I will temporarily submit this as a 'Comment', assuming you don't mind the last request... Great work!

[t-will-gillis]

Thanks @dcotelessa !

[t-will-gillis]

Hi @roslynwythe since you have already Approved this, I will merge this

[dcotelessa]

Adding to this repo is my closed test PR request created:
dcotelessa#2
dcotelessa#3