Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated existing profile of Sanya Nijhawan in Home Unite Us Leadership Section #7628

Merged

Conversation

srinipandiyan
Copy link
Member

@srinipandiyan srinipandiyan commented Oct 23, 2024

Fixes #7489

What changes did you make?

  • Task was to add profile card of Sanya Nijhawan's data to Home Unite Us Leadership Section; however, a profile card with outdated data was already present in thehome-unite-us.md file.
  • I modified the existing profile card to reflect the updated contact info and leadership role as follows:
- name: Sanya Nijhawan
  github-handle: sanya301
  role: Advisory
  links:
    slack: https://hackforla.slack.com/team/U031FLYS561
    github: https://github.com/sanya301
  picture: https://avatars.githubusercontent.com/sanya301

Why did you make the changes (we will use this info to test)?

  • These changes were made to provide end-clients with up-to-date information regarding our partnering organizations through the Hack For LA website.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Before screenshot of Home Unite Us page with updated profile card of Santa Nijhawan
Visuals after changes are applied After screenshot of Home Unite Us page with updated profile card of Santa Nijhawan

@srinipandiyan srinipandiyan added good first issue Good for newcomers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 23, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b srinipandiyan-add-profile-to-home-unite-us-7489 gh-pages
git pull https://github.com/srinipandiyan/website.git add-profile-to-home-unite-us-7489

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe labels Oct 23, 2024
@srinipandiyan srinipandiyan changed the title Updated existing profile of Sanja Nijhawan in Home Unite Us Leadership Section Updated existing profile of Sanya Nijhawan in Home Unite Us Leadership Section Oct 23, 2024
@siyunfeng siyunfeng self-requested a review October 23, 2024 18:38
@siyunfeng
Copy link
Member

siyunfeng commented Oct 23, 2024

Review ETA: 10/23/24 Wednesday
Availability: 6-10 PM Weekdays (EDT)

@floydferrer floydferrer self-assigned this Oct 23, 2024
@floydferrer
Copy link
Member

Review ETA: 10/23/24 Thursday
Availability: 4-10 PM Weekdays (PST)

@floydferrer floydferrer self-requested a review October 23, 2024 19:21
@floydferrer floydferrer removed their assignment Oct 23, 2024
Copy link
Member

@siyunfeng siyunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your second good first issue, @srinipandiyan ! You have been improving your skills and following the guidelines.

  • Availability and ETA are included in the original issue
  • PR is done with the correct branch
  • The linked issue is included and accurate
  • Changes are correct
  • Before-and-after screenshots are provided and you put extra effort into highlighting the difference

Improvement:

  • Name the branch with more specific details, such as update-sanya-nijhawan-profile-home-unite-us-7489

Thank you for your contribution!

@codyyjxn codyyjxn self-requested a review October 24, 2024 01:50
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srinipandiyan Great Job on this issue.

  • The title is good and the description as well.
  • Ran the code on my end and it seems to display the correct changes needed for this page.

Only thing needs to be removed from your pr is …ip section. this is right on top of the fixes maybe just a type-o. Please remove this and the pr will be done.

Keep it up! Thank you for your contribution.

@floydferrer
Copy link
Member

Great job on your second good first issue, @srinipandiyan !

  • PR is done with the correct branch
  • The linked issue is included and accurate
  • Changes are correct
  • Before-and-after screenshots are clear of the requested changes
  • As @codyyjxn mentioned, need to remove "…ip section" from the top of your PR above "Fixes..."

Thanks for your contribution!

@LRenDO LRenDO merged commit e6d0bc1 into hackforla:gh-pages Oct 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Add Sanya Nijhawan
5 participants