Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Emma Thrash from Expunge Assist #7705 #7733

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

codyjohnsontx
Copy link
Member

@codyjohnsontx codyjohnsontx commented Nov 19, 2024

Fixes #7705

What changes did you make?

  • Remove Emma Thrash from Expunge Assist Current Team

Why did you make the changes (we will use this info to test)?

  • To keep list of Current Project Team up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

emma_thrash_before

Visuals after changes are applied

emma_thrash_after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b codyjohnsontx-remove-emma-thrash-7705 gh-pages
git pull https://github.com/codyjohnsontx/website.git remove-emma-thrash-7705

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 19, 2024
@mchait18
Copy link
Member

Review ETA: 12 PM 11/20/24
Availability: 9-3 EST M-F

Copy link
Member

@mchait18 mchait18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The PR contains the correct branch
  • issue is correctly linked
  • changes are verified across browsers (firefox, edge, chrome)
  • code changes are accurate and concise
  • no other notable issues
    Great job!

@belunatic
Copy link
Member

Review ETA: 12 PM 11/22/24
Availability: 4-5 M

Copy link
Member

@belunatic belunatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codyjohnsontx great job! All looks good

few suggestion

  • it will be helpful for the branch name to be more descriptive, maybe added a project emma is in, ex: remove-emma-thrash-expung-assist-7705
  • What has changed section can be more descriptive to, let us know what file changed, will help us going back and forth between the issue and PR to see what file need to be changed

Besides that , thank you very much @codyjohnsontx!

Copy link
Member

@santisecco santisecco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @codyjohnsontx everything looks great. Branches, screenshots and code changes are correct. Also the What and Why sections. Though for next time, as a tip to help other developers, please add the files you changed in the What section. For example:
"Modified the _projects/expunge-assist.md file" or something of your choice of course.
Thanks for working on this, great job.

@codyjohnsontx
Copy link
Member Author

Update

  1. All finished, made notes in my own documentation about what to do better according to the reviews above. Only awaiting merge pull request to delete branch and continue on
  2. None
  3. M-F 3-7pm, 9pm-10pm
  4. ETA: EOD 11/21/24

@jphamtv jphamtv merged commit 0e4062e into hackforla:gh-pages Nov 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist Remove Emma Thrash
6 participants