-
-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Emma Thrash from Expunge Assist #7705 #7733
remove Emma Thrash from Expunge Assist #7705 #7733
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 12 PM 11/20/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The PR contains the correct branch
- issue is correctly linked
- changes are verified across browsers (firefox, edge, chrome)
- code changes are accurate and concise
- no other notable issues
Great job!
Review ETA: 12 PM 11/22/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codyjohnsontx great job! All looks good
few suggestion
- it will be helpful for the branch name to be more descriptive, maybe added a project emma is in, ex:
remove-emma-thrash-expung-assist-7705
- What has changed section can be more descriptive to, let us know what file changed, will help us going back and forth between the issue and PR to see what file need to be changed
Besides that , thank you very much @codyjohnsontx!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @codyjohnsontx everything looks great. Branches, screenshots and code changes are correct. Also the What and Why sections. Though for next time, as a tip to help other developers, please add the files you changed in the What section. For example:
"Modified the _projects/expunge-assist.md
file" or something of your choice of course.
Thanks for working on this, great job.
Update
|
Fixes #7705
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied