-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Member Anousha Shadrach From LA TDM Calculator #7768
Remove Member Anousha Shadrach From LA TDM Calculator #7768
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 1 PM 11/26/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue, @dvernon5 !
You're doing these right:
- The branch you made the change on is correct
- The linked issue (original issue) number is included
- The content required to remove is accurate
- The before / after screenshot is helpful to display the change
Changes you need to make:
-
Address the questions from HackforLABot in the original issue ( comment your Availability and ETA)
-
The items on the original issue should be checked off when items are addressed
-
You can re-request me to review your PR once you make the changes. Feel free to reach out if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvernon5 great job on taking this gfi.
Things that went well
- The branch name is correct
- The issue is linked
- The before and after photos are great
Some suggestions
- You need to respond to the HackForLA bot in the issue
- You need to check the boxes from the original issue as well
- You can also remove the issue number from the title
Keep it up !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are perfect, you did exactly what the issue specified.
Branch name looks good.
For the "Why did you make the changes?" section, don't just say that the issue specified it, say why did the issue specify it.
Overall looks good to me.
Thank you for your feedback. I took your advice and re-edit my answer to the given question "Why did you make the changes?". I hope that is a better response. Thank you once again. |
Review ETA: 2 PM 11/26/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvernon5 great job successfully removing Anousha Shadrach from the LA TCM Calculator.
Things that went well
-The branch name is correct
-The issue is linked
-The before and after photos are great
-You responded to the bot
-You removed the issue number from the title
@rachelcorawood |
Review ETA: 4:30pm 11/26/2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch name looks good
The code changes look perfect.
The issue is linked correctly
CodeQL alerts are good
The content removed is corrrect
Before and After photos look great
Good job on the PR @dvernon5 and thank you for your time
Thank you for your feedback and time. I truly appreciate it, and I am glad everything is looking good. |
Fixes #7651
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied