Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for Priyanka Jujjavarapu to the website #7834

Merged

Conversation

lc1715
Copy link
Member

@lc1715 lc1715 commented Jan 18, 2025

Fixes #7751

What changes did you make?

  • Added profile for Priyanka Jujjavarapu to the website

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

img 1

Visuals after changes are applied

img 2

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b lc1715-website-add-priyanka-jujjavarapu-7751 gh-pages
git pull https://github.com/lc1715/website.git website-add-priyanka-jujjavarapu-7751

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 18, 2025
@mugdhchauhan mugdhchauhan self-requested a review January 19, 2025 16:12
@mugdhchauhan
Copy link
Member

Review ETA: 19 Jan 2025 @ 6 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lc1715, thanks for working on this!

Kudos

  • The pull request is made with the correct branch.
  • The pull request post contains a linked issue, what changes you made and why are clear, and the screenshots section is complete.
  • The changes to the _projects/website.md file are accurate.
  • I can see the changes in my local environment.
  • You have claimed the issue well and provided availability and ETA.

Suggested changes

Please make the following change(s) to the PR post:

  • For the "CodeQL Alerts" section, please check off the relevant checkbox(es).

After you have done this, re-request a review from me. Feel free to reach out if you need help with anything.

@lc1715
Copy link
Member Author

lc1715 commented Jan 21, 2025

Thank you @mugdhchauhan for reviewing my first pull request! I looked for the CodeQL alerts for this PR and none were found. Please let me know if there is anything else I need to do!

@mugdhchauhan
Copy link
Member

Review ETA: 21 Jan 2025 @ 6 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lc1715, you did great for your first pull request! Thank you for making the changes. I have approved this PR now. 👍

You could also check off the checkbox in the previous review above. 🙂

@lc1715
Copy link
Member Author

lc1715 commented Jan 21, 2025

Done! :)

@DrAcula27 DrAcula27 self-requested a review January 21, 2025 20:32
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lc1715 Great job on your Good First Issue! Your code passed the ABC's, including:

  • PR is made from the correct branch
  • PR links to the correct issue:
  • The correct file _projects/website.md was edited
  • No extra edits were made
  • Appearance of the website looks good (Chrome and Firefox)
  • Thanks for being so responsive when the first reviewer requested changes as well, that helps a lot
    Approved! 👍

@lc1715
Copy link
Member Author

lc1715 commented Jan 22, 2025

@DrAcula27 Thank you for reviewing the pull request!

Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the changes are correct and appear the right way on the page, will now merge! Thanks for working on this :)

@k-cardon k-cardon merged commit a682be2 into hackforla:gh-pages Jan 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Add Priyanka Jujjavarapu
4 participants