Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Website Add Siyun Feng #7899

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

DDVVPP
Copy link
Member

@DDVVPP DDVVPP commented Feb 6, 2025

Fixes #7774

What changes did you make?

  • Added Siyun Feng to leadership in the website markdown file

Why did you make the changes (we will use this info to test)?

  • To keep the list of current project team members up to date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied current project team-before
Visuals after changes are applied current project team-after

Copy link

github-actions bot commented Feb 6, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b DDVVPP-update-project-profile-add-7774 gh-pages
git pull https://github.com/DDVVPP/HackForLA-Website.git update-project-profile-add-7774

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 6, 2025
@phunguyen1195 phunguyen1195 self-requested a review February 7, 2025 01:12
@phunguyen1195
Copy link
Member

Review ETA: EOD 2/9/25
Availability: W & F

@lc1715 lc1715 self-requested a review February 7, 2025 05:49
@lc1715
Copy link
Member

lc1715 commented Feb 7, 2025

Review ETA: EOD 2/6/25
Availability: 1-7 PM Mon-Fri

lc1715
lc1715 previously approved these changes Feb 7, 2025
Copy link
Member

@lc1715 lc1715 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DDVVPP Great job on your good first issue!👍

  • The PR is done with the correct branch and linked issue
  • You added the profile into the _projects/website.md file
  • The applicable changes can be seen in the browser and source code looks good

@trimakichan
Copy link
Member

Review ETA: EOD 2/11/25
Availability: 10 AM - 4 PM PST, Mon-Fri

Copy link
Member

@trimakichan trimakichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DDVVPP, great job on this issue!

  • The pull request is made with the correct branch.
  • The issue is correctly linked.
  • The changes are displayed properly.
  • All links for Siyun Feng are working.

Suggestions:

Consider using a more descriptive branch name, such as "add-Siyun-Feng-profile-website-7774", for better clarity.

Thank you for your contribution! 🎉

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DDVVPP!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site - Siyun Feng has been added
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated

A small note for the future, here it's not much of an issue because only a small amount of white space was removed, but in general it's good to make sure that your pull requests only include what is required for the issue.

Again, great work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit e869548 into hackforla:gh-pages Feb 13, 2025
3 checks passed
- name: Amen Divine Ikamba
github-handle: amen-ikamba
role: Product Manager - Dashboards
links:
slack: https://hackforla.slack.com/team/U07T35HCHAN
github: https://github.com/amen-ikamba
picture: https://avatars.githubusercontent.com/amen-ikamba
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LRenDO it looks like there was an extra space here that perhaps shouldn't have been here? My ESLint in VSCode auto-formatted this on save. Is there a work around to leave as is - perhaps I missed the eslint config requirements!

@DDVVPP DDVVPP deleted the update-project-profile-add-7774 branch February 14, 2025 03:08
Khinememe-Kyaw pushed a commit to Khinememe-Kyaw/website that referenced this pull request Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Website Add Siyun Feng
5 participants