-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Website Add Siyun Feng #7899
Update Project Profile: Website Add Siyun Feng #7899
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: EOD 2/9/25 |
Review ETA: EOD 2/6/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DDVVPP Great job on your good first issue!👍
- The PR is done with the correct branch and linked issue
- You added the profile into the
_projects/website.md
file - The applicable changes can be seen in the browser and source code looks good
Review ETA: EOD 2/11/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DDVVPP, great job on this issue!
- The pull request is made with the correct branch.
- The issue is correctly linked.
- The changes are displayed properly.
- All links for Siyun Feng are working.
Suggestions:
Consider using a more descriptive branch name, such as "add-Siyun-Feng-profile-website-7774", for better clarity.
Thank you for your contribution! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DDVVPP!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site - Siyun Feng has been added
- Relevant images were included to show visual changes
- The PR request clearly states what was updated
A small note for the future, here it's not much of an issue because only a small amount of white space was removed, but in general it's good to make sure that your pull requests only include what is required for the issue.
Again, great work and thanks for taking the time to contribute to the website!
- name: Amen Divine Ikamba | ||
github-handle: amen-ikamba | ||
role: Product Manager - Dashboards | ||
links: | ||
slack: https://hackforla.slack.com/team/U07T35HCHAN | ||
github: https://github.com/amen-ikamba | ||
picture: https://avatars.githubusercontent.com/amen-ikamba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LRenDO it looks like there was an extra space here that perhaps shouldn't have been here? My ESLint in VSCode auto-formatted this on save. Is there a work around to leave as is - perhaps I missed the eslint config requirements!
Fixes #7774
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied