Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for Safari Browser #51

Closed
wants to merge 2 commits into from

Conversation

trojanh
Copy link

@trojanh trojanh commented Sep 18, 2018

Current this Package doesnt work on Safari, we get following error on console:

Unhandled Promise Rejection: ReferenceError: Can't find variable: MediaRecorder
(anonymous function) — MicrophoneRecorder.js:61
promiseReactionJob
startRecording — MicrophoneRecorder.js:55

I have added audio-recorder-polyfill package to allow support for audio recording in Safari and Edge using polyfill.

@hackingbeauty
Copy link
Owner

hackingbeauty commented Sep 18, 2018

@trojanh thanks you for this PR!!

However, I tested it out and the audio is not recording properly. There's a lot of static in the audio and I'm not sure why. I think it may be related to this issue in the audio-recorder-polyfill or the way WAV files need to be processed.

Can you help us figure this out? Thank you!!! :)

@trojanh
Copy link
Author

trojanh commented Sep 20, 2018

Hi @hackingbeauty I was trying to find a solution to the problem you mentioned. Then I discovered
this https://github.com/addpipe/simple-recorderjs-demo which uses Recorderjs to record audio. I tested it on Safari, Chrome and Firefox and seemed to me it works best.

I also explored your code and found that you aren't using Recorderjs so I wasn't able to integrate it. I wanted explore this and then we can collectively use it here.

You can start with demo here

Also worth checking web-audio-recorder demo and implementation.

As per what I have learned, its seems Media Recorder API is specifically not supproted by Safari and IE and also doesnt allow us to get audio in mp3 format. So we can consider Recorderjs and Web Audio Recorder apis.

Let me know your thoughts if you have already brainstromed these APIs.

@hackingbeauty
Copy link
Owner

Sorry, not merging this. Doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants