-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyproject.toml to config black line length #258
Conversation
@ardunn Like you said, there seems to be a problem with code style. But I'm not sure it's the code. The #!/bin/bash -eo pipefail
source dev_scripts/setup_env_dev.sh
source dev_scripts/run_code_style_check.sh
WARNING: You are using pip version 19.3; however, version 19.3.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
Exited with code 1 Similarly, the tests fail with something that seems unrelated to the changes in this PR. RuntimeError: implement_array_function method already has a docstring
2019-10-23 09:43:30,877 - ERROR - environment variable CODACY_PROJECT_TOKEN is not defined.
Exited with code 1 |
Coce styleOk so @janosh I ssh'd into your build and ran the script manually:
I just don't think CircleCI prints the output sometimes if a command exits with code 1. Tests failingThe tests actually passed. The environment variable thing is another CircleCI problem (I posted a question on the forum about it). Don't worry about it, when the code_style stuff is fixed I'll just merge it and trigger the tests myself (which would fix this env var issue until CircleCI gets back to me) :) Edit: Note to self- https://circleci.com/blog/managing-secrets-when-you-have-pull-requests-from-outside-contributors/ |
Sorry, this is my mistake. Looks like we need a |
@janosh would it be possible to revert the formatting on these files and just PR the config changes? I can reformat on my own but it is hard to review 55 files before merging to the master branch Again thanks so much for the PR!!! |
@ardunn Done. |
@ardunn Anything left to do here? |
@janosh thanks again! |
Follow up to this comment.