Include Lift and Scala version numbers in package name #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lift 3.0 and 3.1 libs are not guaranteed to be mutually compatible. The same for various Scala versions project is compiled for. In order to let developers refer to the right version, we put Lift and Scala version number in package name.
Open
Shadowfiend
reviewed
Jan 10, 2018
| @@ -1,25 +1,33 @@ | |||
| val liftVersion = settingKey[String]("Lift Web Framework full version number") | |||
| val liftEdition = settingKey[String]("Lift Edition (such as 2.6 or 3.0)") | |||
There was a problem hiding this comment.
Any reason to have these be settingKey instead of just val?
There was a problem hiding this comment.
Building for multiple Scala versions is easy - we can just add crossScalaVersions (which I didn't add here because I see it in #26) and it works out of the box. However, I haven't seen so far anything like that for building against different library versions. With settingKey we can do just:
> set liftVersion:="2.6"
[info] Defining *:liftVersion
[info] The new value will be used by *:libraryDependencies, *:liftEdition
[info] Reapplying settings...
[info] Set current project to lift-formality (in build file:/Users/piotr/git/lift-formality/)
> package
(...)
[info] Packaging /Users/piotr/git/lift-formality/target/scala-2.11/lift-formality_2.6_2.11-1.1.0-SNAPSHOT.jar ...
[info] Done packaging.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lift 3.0 and 3.1 libs are not guaranteed to be mutually compatible. The same for various Scala versions project is compiled for.
In order to let developers refer to the right version, we put Lift and Scala version number in package name.
For example: