-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/fixed phone number input #1006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded phone number field to account creation.
…'t default to 11111111111
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MikaVohl
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tektaxi
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
tektaxi
added a commit
that referenced
this pull request
Nov 15, 2024
…#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
tektaxi
added a commit
that referenced
this pull request
Nov 15, 2024
…#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
tektaxi
added a commit
that referenced
this pull request
Nov 15, 2024
* Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
tektaxi
added a commit
that referenced
this pull request
Nov 15, 2024
* Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Fix/update grad years (#1015) * Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com>
tektaxi
added a commit
that referenced
this pull request
Dec 7, 2024
* Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Fix/update grad years (#1015) * Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Accomodate intl phone numbers in account creation * Changed conditional rendering for editing phone number in ManageAccountForm.tsx * Updated hacker export by removing/commenting out fields that don't exist anymore, and adding new fields to match current account/application form. --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com>
tektaxi
added a commit
that referenced
this pull request
Dec 7, 2024
* Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Fix/update grad years (#1015) * Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Accomodate intl phone numbers in account creation * Changed conditional rendering for editing phone number in ManageAccountForm.tsx * Updated hacker export by removing/commenting out fields that don't exist anymore, and adding new fields to match current account/application form. * switch csv export to tsv to avoid input errors --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com>
tektaxi
added a commit
that referenced
this pull request
Dec 7, 2024
* Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Fix/update grad years (#1015) * Add 3rd checkbox to Terms and Conditions #1010 * Update Grad Years in Filter * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Clear the fields and add success message after sending account invite (#1008) * change-mchacks12 * change-mchacks12 * Remove Netlify link from README * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * Fix/fixed phone number input (#1006) * Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> * add success message and reset fields after an invite is successfully sent * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Add 3rd checkbox to Terms and Conditions (#1012) * Add 3rd checkbox to Terms and Conditions #1010 * MLH Form Changes (#1016) * Updated level of study options to match MLH requirements * #1000 - Update export from .tsv to .csv * Changed hacker account form 'birthdate' field to 'age' #1003 * Added country of residence field to Other/Personal Details section of hacker application #1009 * Added country of residence field to the hacker application. * add back CEGEP level of study. --------- Co-authored-by: allennatang <allennatang@gmail.com> * Added Jamie's changes for MLH checkbox, fixed merge conflicts. * fixed dumb rebase error --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * change-mchacks12 --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> --------- Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: allennatang <allennatang@gmail.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Accomodate intl phone numbers in account creation * Changed conditional rendering for editing phone number in ManageAccountForm.tsx * Updated hacker export by removing/commenting out fields that don't exist anymore, and adding new fields to match current account/application form. * switch csv export to tsv to avoid input errors * fixed the comma separation, changed to csv --------- Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
List of changes:
Type of change:
Please delete options that aren't relevant.
How did you do this?
deleted some code
How to test:
make an account with a phone number and check the phone number in the manage account page
Questions:
PR Checklist:
develop
branch (before testing)Screenshots: