Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow native spell check correction of words #150

Open
csuwildcat opened this issue Aug 5, 2016 · 13 comments
Open

Allow native spell check correction of words #150

csuwildcat opened this issue Aug 5, 2016 · 13 comments
Labels
enhancement Wants to improvide an existing feature help wanted We want you to help us with this!

Comments

@csuwildcat
Copy link

I came up with a hack that could possibly be used to enable native spell check for browsers that support it: http://codepen.io/csuwldcat/pen/mEzGmP?editors=0010

I noticed that clicks are still registered on the spans of words, so I figured I could clone the word on double click and make the clone contenteditable with spellchecking turned on. From there I mask the original, allow the user to right click the misspelled word, then reflect the change on the original text by copying the corrected text to it.

@jackycute
Copy link
Member

@csuwildcat Thank you!
I tested Chrome 52 on my Mac, but the suggestion still not working.
Firefox always works so that might be Chrome's setting or issue.

But this might take times to hack into CodeMirror to figure out how to.
Please be patient. Thanks again.

@jackycute
Copy link
Member

Oh another thing is the cursor will jump to the front of the word when you double clicking it.
It would be nice if you could inspect how to avoid that 😄

@csuwildcat
Copy link
Author

I had only spent a few minutes on the first hack, so I bet I can figure out
the other issues you mentioned. Probably can take a look at the end of the
week, I am at a work offsite for the next few days.

On Sun, Aug 7, 2016 at 8:02 PM, Max Wu notifications@github.com wrote:

Oh another thing is the cursor will jump to the front of the word when you
double clicking it.
It would be nice if you could inspect how to avoid that 😄


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#150 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAICyiSiDEgTmDdfurC9JHPj-umTk99Pks5qdpxVgaJpZM4JeC5j
.

@jackycute jackycute added the enhancement Wants to improvide an existing feature label Sep 9, 2016
@jackycute
Copy link
Member

@ccoenen
Copy link
Contributor

ccoenen commented Aug 2, 2017

@csuwildcat did you make any progress with that?

@ccoenen ccoenen added the help wanted We want you to help us with this! label Oct 6, 2017
@ccoenen
Copy link
Contributor

ccoenen commented Oct 6, 2017

I think this is one of the most important issues, now that HackMD is used by a wider audience.

@kinetifex
Copy link

Hey, I ended up here, after looking into HackMD compatibility with Grammarly. I recently discovered HackMD and am loving it.

Is there any work being done towards this issue? Any place where we can vote for issues to be prioritized?

@SISheogorath
Copy link
Contributor

@kinetifex sadly, there is currently no way to put grammarly support into HackMD. The way the editor framework codemirror composes the editing section makes it hard, to impossible for Grammarly to hook into this. And as Grammarly is not open source, it can't be modified to work with some kind of codemirror addons.

@kinetifex
Copy link

@SISheogorath bummer. Thanks for the quick response.

@SISheogorath
Copy link
Contributor

You're welcome, even when the answer you got probably doesn't make you really happy :)

@PenguinOwl
Copy link

Is there a way to spell check currently? An in-editor implementation would be the next best thing and would be very helpful.

@SISheogorath
Copy link
Contributor

SISheogorath commented Feb 14, 2019

@PenguinOwl, there is:

Spellcheck check mark in the editor toolbar

The check mark in the lower toolbar enables spell checking. But it's far from being perfect. It tells you that something is wrong, or unknown, but doesn't suggest how to correct it, which makes it way less useful than it should be. Also it only supports english language, so if anyone want to put work into this, it would be very, very welcome 👍

@SISheogorath SISheogorath removed this from the Backlog milestone Mar 23, 2019
@robert-zaremba
Copy link

UP. Is there any way I can use native spell check to let my browser suggest a corrections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Wants to improvide an existing feature help wanted We want you to help us with this!
Projects
None yet
Development

No branches or pull requests

8 participants