Skip to content

Add more tests #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SISheogorath opened this issue Oct 30, 2017 · 2 comments
Closed

Add more tests #611

SISheogorath opened this issue Oct 30, 2017 · 2 comments
Labels
discussion Exchange of some opinions needed enhancement Wants to improvide an existing feature help wanted We want you to help us with this! refactor

Comments

@SISheogorath
Copy link
Contributor

SISheogorath commented Oct 30, 2017

We currently only do static code analysis on our codebase. This prevents broken syntaxes but doesn't prevent logical errors.

And while static-typed languages provide a little bit of security for not breaking things without a compiler error, in JS that's totally possible. To prevent this we need runtime tests. Unit tests using a framework like mocha or jasmine would be awesome! It needs a lot of work but it would help to stabilize the code base a lot.

It's an annoying task, I know and for most people, no fun. But I'm not the JS test guru I should be for this task, so I would really appreciate help with this. The basic setup, the concept where to place the tests (in a separate directory or along with the files but with a .test.js file ending). How to make these tests not breaking our webpack setup and so on?

As you know since #579 we as a community develop HackMD CE now and we have to decide where we want to go. Right now, I try to stabilize the code base and fix existing bugs instead of providing more and more new features. With tests, we can go further and make it easier to verify new features and prevent them from breaking existing ones.

I love working on HackMD as well as I enjoy having this community! So let's work on it as a community and improve HackMD CE!

Pull Request, concepts, examples, and ideas are very welcome! ❤️

Also feel free to meet me in our Gitter-Space: Join the chat at https://gitter.im/hackmdio/hackmd

Newer duplicate of #22

@SISheogorath SISheogorath added discussion Exchange of some opinions needed enhancement Wants to improvide an existing feature help wanted We want you to help us with this! refactor labels Oct 30, 2017
@SISheogorath SISheogorath added the duplicate This issue or pull request already exists label Oct 31, 2017
@ccoenen ccoenen mentioned this issue Jun 26, 2018
@ccoenen ccoenen removed the duplicate This issue or pull request already exists label Jun 26, 2018
@ccoenen
Copy link
Contributor

ccoenen commented Jun 26, 2018

let's continue here, no need to keep two versions of this ticket open.

@SISheogorath
Copy link
Contributor Author

Asked Cloudron to add their tests to our repository:

https://git.cloudron.io/cloudron/codimd-app/issues/2

JJediny pushed a commit to 18F/codimd-cloudgov-template that referenced this issue Dec 16, 2020
Change label used by renovate to "type: maintenance"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Exchange of some opinions needed enhancement Wants to improvide an existing feature help wanted We want you to help us with this! refactor
Projects
None yet
Development

No branches or pull requests

2 participants